[Part 1 of 3] v4-core dependency + gas snapshot + ci runs tweak (s52) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
commented
Jan 26, 2025
Comment on lines
-29
to
-30
| call_override = false # Override calls | ||
| fail_on_revert = false # Fail the test if the contract reverts |
There was a problem hiding this comment.
seems like this 2 is already false from foundry https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md
ChefMist
commented
Jan 26, 2025
| @@ -16,23 +16,17 @@ evm_version = 'cancun' | |||
| bytecode_hash = "none" | |||
|
|
|||
| [fuzz] | |||
| runs = 1000 # change this for higher number of fuzz/invariant locally | |||
| runs = 5 # change this for higher number of fuzz runs locally | |||
There was a problem hiding this comment.
set lower fuzz/invariant runs locally, so dev local forge test is faster by default. they can always override and set higher if required
ChefMist
commented
Jan 26, 2025
| @@ -23,7 +23,7 @@ jobs: | |||
| - name: Install Foundry | |||
| uses: foundry-rs/foundry-toolchain@v1 | |||
| with: | |||
| version: nightly-471e4ac317858b3419faaee58ade30c0671021e0 # Nightly (2024-10-03) | |||
| version: stable | |||
There was a problem hiding this comment.
use stable as local foundry is stable too
ChefMist
commented
Jan 26, 2025
|
|
||
| [profile.ci_main.fuzz] | ||
| runs = 100000 | ||
| runs = 1000 |
There was a problem hiding this comment.
lower for now - otherwise ci will fail (timeout) - https://github.com/pancakeswap/pancake-v4-periphery/issues/73
we can visit that issue again if we have time and see whats a suitable number
ChefMist
changed the title
ChefMist
changed the title
ChefMist
changed the title
chefburger
previously approved these changes
Jan 27, 2025
ChefSnoopy
previously approved these changes
Jan 27, 2025
* feat: increase optimizer runs * [Part 3 of 3] Code factoring (s43, s48, s50) (#76) * s43: interface doc update * s48: use directive with global * s50: use internal keyword to make visibility obvious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As https://github.com/pancakeswap/pancake-v4-periphery/pull/66 is getting messy, this 3 part PR series aim to split the PR into a few chunks thats easy to review
This part will
s52: migrate from gas snapshot to native snapshot