-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part 2 of 2] feat: internal feedback: remove gasSnapshot and use native snapshot #67
Conversation
migrator.multicall(data); | ||
snapEnd(); | ||
vm.snapshotGasLastCall(string(abi.encodePacked(_getContractName(), "#testMigrateFromV2IncludingInit"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why would we need _getContractName
here since by default the snapshot file already named as test file name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and somehow the snapshot is not generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, yeh _getContractName()
no longer needed since each gas snapshot stored under file name, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add husky pre-commit hook for snapshots auto generation and git commit? |
created this issue to track - https://github.com/pancakeswap/pancake-v4-periphery/issues/69 i think there's pro & cons, lets discuss internally first 👍 |
merging to https://github.com/pancakeswap/pancake-v4-periphery/pull/66 so #65 will pass |
This PR remove
gasSnapshot
and use native snapshotBuilt as separate PR so its easier to review