-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: internal feedback #66
Changes from all commits
e24d09f
73720ae
c3e8c38
5a81579
9f215ac
c8b2f62
0edb489
15db55e
71521b1
489937f
ca93ee7
9df3f60
67c9eab
1b3d616
b41a48d
9b1a893
68ddff8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"BaseActionsRouter_mock10commands": "82785" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"testMigrateFromV2IncludingInit": "1176442", | ||
"testMigrateFromV2WithoutInit": "1046490", | ||
"testMigrateFromV2WithoutNativeToken": "1087310" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"BinMigratorBytecodeSize": "15187", | ||
"testMigrateFromV3IncludingInit": "1248658", | ||
"testMigrateFromV3WithoutInit": "1118687", | ||
"testMigrateFromV3WithoutNativeToken": "1153511" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"testMigrateFromV2IncludingInit": "1176442", | ||
"testMigrateFromV2WithoutInit": "1046490", | ||
"testMigrateFromV2WithoutNativeToken": "1087310" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"BinMigratorBytecodeSize": "15187", | ||
"testMigrateFromV3IncludingInit": "1246640", | ||
"testMigrateFromV3WithoutInit": "1116669", | ||
"testMigrateFromV3WithoutNativeToken": "1151493" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"BinPositionManagerBytecode size": "17435" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"test_addLiquidity_OutsideActiveId_ExistingId": "292694", | ||
"test_addLiquidity_OutsideActiveId_NewId": "1124993", | ||
"test_addLiquidity_SingleBin": "532073", | ||
"test_addLiquidity_ThreeBins": "905930", | ||
"test_decreaseLiquidity_threeBins": "184859", | ||
"test_decreaseLiquidity_threeBins_half": "203748" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"test_addLiquidity": "847340", | ||
"test_addLiquidity_excessEth": "849077", | ||
"test_decreaseLiquidity": "191515" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"BinQuoterBytecode size": "6839" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"testExactInputSingle_DifferentRecipient": "136133", | ||
"testExactInputSingle_EthPool_SwapEthForToken": "124501", | ||
"testExactInputSingle_EthPool_SwapTokenForEth": "110210", | ||
"testExactInput_MultiHopDifferentRecipient": "166964", | ||
"testExactOutputSingle_DifferentRecipient": "140509", | ||
"testExactOutput_MultiHopDifferentRecipient": "170820", | ||
"testExactOutput_SingleHop": "142184" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"testCLMigrateFromV2IncludingInit": "789904", | ||
"testCLMigrateFromV2WithoutInit": "658970", | ||
"testCLMigrateFromV2WithoutNativeToken": "729264" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"CLMigratorBytecodeSize": "13782", | ||
"testCLMigrateFromV3IncludingInit": "839793", | ||
"testCLMigrateFromV3WithoutInit": "708840", | ||
"testCLMigrateFromV3WithoutNativeToken": "752181" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"testCLMigrateFromV2IncludingInit": "789916", | ||
"testCLMigrateFromV2WithoutInit": "658982", | ||
"testCLMigrateFromV2WithoutNativeToken": "729264" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"CLMigratorBytecodeSize": "13782", | ||
"testCLMigrateFromV3IncludingInit": "837775", | ||
"testCLMigrateFromV3WithoutInit": "706822", | ||
"testCLMigrateFromV3WithoutNativeToken": "750163" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"CLPositionDescriptorOffChainSize": "2958" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems useful 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw u deleted it in the end. Curious would we even have a bigger optimizer_runs if we keep it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad -- added back in https://github.com/pancakeswap/pancake-v4-periphery/pull/66/commits/9df3f60086f382fa95ca78cb5e889e1766477aeb
the bytecode size test for CLPositionManager was wrong, i used
manager
which was CLPoolManager. after updating to CLPositionManager, it became 28kb (larger than 24kb limit)so added back s41 to compile
9000
runs for CLPositionManager and the rest having1_000_000
runs