Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: internal feedback #66

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .forge-snapshots/BaseActionsRouter_mock10commands.snap

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionDescriptorOffChainSize.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_burn_empty.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_burn_empty_native.snap

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_collect_native.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_collect_sameRange.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_collect_withClose.snap

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_decrease_burnEmpty.snap

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_decrease_take_take.snap

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_mint_native.snap

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_mint_sameRange.snap

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_mint_withClose.snap

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_permit.snap

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_permit_twice.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_subscribe.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLPositionManager_unsubscribe.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLSwapRouterTest#ExactInput.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLSwapRouterTest#ExactInputSingle.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLSwapRouterTest#ExactOutput.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/CLSwapRouterTest#ExactOutputSingle.snap

This file was deleted.

11 changes: 10 additions & 1 deletion foundry.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
src = 'src'
out = 'foundry-out'
solc_version = '0.8.26'
optimizer_runs = 9000
optimizer_runs = 1_000_000
via_ir = true
ffi = true
gas_limit = "3000000000"
Expand All @@ -15,6 +15,15 @@ fs_permissions = [
evm_version = 'cancun'
bytecode_hash = "none"

# more info about compiler_profiles and restrictions here https://github.com/foundry-rs/foundry/pull/8668
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems useful 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw u deleted it in the end. Curious would we even have a bigger optimizer_runs if we keep it ?

Copy link
Collaborator Author

@ChefMist ChefMist Jan 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad -- added back in https://github.com/pancakeswap/pancake-v4-periphery/pull/66/commits/9df3f60086f382fa95ca78cb5e889e1766477aeb

the bytecode size test for CLPositionManager was wrong, i used manager which was CLPoolManager. after updating to CLPositionManager, it became 28kb (larger than 24kb limit)

so added back s41 to compile 9000 runs for CLPositionManager and the rest having 1_000_000 runs

additional_compiler_profiles = [
{ name = "clPosm", optimizer_runs = 9000 }
]

compilation_restrictions = [
{ paths = "src/pool-cl/CLPositionManager.sol", optimizer_runs = 9000 }
]

[fuzz]
runs = 1000 # change this for higher number of fuzz/invariant locally

Expand Down
2 changes: 1 addition & 1 deletion lib/pancake-v4-core
3 changes: 3 additions & 0 deletions snapshots/BaseActionsRouterTest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"BaseActionsRouter_mock10commands": "82785"
}
5 changes: 5 additions & 0 deletions snapshots/BinMigratorFromPancakeswapV2Test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"testMigrateFromV2IncludingInit": "1176442",
"testMigrateFromV2WithoutInit": "1046490",
"testMigrateFromV2WithoutNativeToken": "1087310"
}
6 changes: 6 additions & 0 deletions snapshots/BinMigratorFromPancakeswapV3Test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"BinMigratorBytecodeSize": "15187",
"testMigrateFromV3IncludingInit": "1248658",
"testMigrateFromV3WithoutInit": "1118687",
"testMigrateFromV3WithoutNativeToken": "1153511"
}
5 changes: 5 additions & 0 deletions snapshots/BinMigratorFromUniswapV2Test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"testMigrateFromV2IncludingInit": "1176442",
"testMigrateFromV2WithoutInit": "1046490",
"testMigrateFromV2WithoutNativeToken": "1087310"
}
6 changes: 6 additions & 0 deletions snapshots/BinMigratorFromUniswapV3Test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"BinMigratorBytecodeSize": "15187",
"testMigrateFromV3IncludingInit": "1246640",
"testMigrateFromV3WithoutInit": "1116669",
"testMigrateFromV3WithoutNativeToken": "1151493"
}
3 changes: 3 additions & 0 deletions snapshots/BinPositionManagerTest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"BinPositionManagerBytecode size": "17435"
}
8 changes: 8 additions & 0 deletions snapshots/BinPositionManager_ModifyLiquidityTest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"test_addLiquidity_OutsideActiveId_ExistingId": "292694",
"test_addLiquidity_OutsideActiveId_NewId": "1124993",
"test_addLiquidity_SingleBin": "532073",
"test_addLiquidity_ThreeBins": "905930",
"test_decreaseLiquidity_threeBins": "184859",
"test_decreaseLiquidity_threeBins_half": "203748"
}
5 changes: 5 additions & 0 deletions snapshots/BinPositionManager_NativeTokenTest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"test_addLiquidity": "847340",
"test_addLiquidity_excessEth": "849077",
"test_decreaseLiquidity": "191515"
}
3 changes: 3 additions & 0 deletions snapshots/BinQuoterTest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"BinQuoterBytecode size": "6839"
}
9 changes: 9 additions & 0 deletions snapshots/BinSwapRouterTest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"testExactInputSingle_DifferentRecipient": "136133",
"testExactInputSingle_EthPool_SwapEthForToken": "124501",
"testExactInputSingle_EthPool_SwapTokenForEth": "110210",
"testExactInput_MultiHopDifferentRecipient": "166964",
"testExactOutputSingle_DifferentRecipient": "140509",
"testExactOutput_MultiHopDifferentRecipient": "170820",
"testExactOutput_SingleHop": "142184"
}
5 changes: 5 additions & 0 deletions snapshots/CLMigratorFromPancakeswapV2Test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"testCLMigrateFromV2IncludingInit": "789904",
"testCLMigrateFromV2WithoutInit": "658970",
"testCLMigrateFromV2WithoutNativeToken": "729264"
}
6 changes: 6 additions & 0 deletions snapshots/CLMigratorFromPancakeswapV3Test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"CLMigratorBytecodeSize": "13782",
"testCLMigrateFromV3IncludingInit": "839793",
"testCLMigrateFromV3WithoutInit": "708840",
"testCLMigrateFromV3WithoutNativeToken": "752181"
}
5 changes: 5 additions & 0 deletions snapshots/CLMigratorFromUniswapV2Test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"testCLMigrateFromV2IncludingInit": "789916",
"testCLMigrateFromV2WithoutInit": "658982",
"testCLMigrateFromV2WithoutNativeToken": "729264"
}
6 changes: 6 additions & 0 deletions snapshots/CLMigratorFromUniswapV3Test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"CLMigratorBytecodeSize": "13782",
"testCLMigrateFromV3IncludingInit": "837775",
"testCLMigrateFromV3WithoutInit": "706822",
"testCLMigrateFromV3WithoutNativeToken": "750163"
}
3 changes: 3 additions & 0 deletions snapshots/CLPositionDescriptorOffChainTest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"CLPositionDescriptorOffChainSize": "2958"
}
Loading
Loading