Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the PowerDNS-Admin API #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmuncks
Copy link

@tmuncks tmuncks commented Oct 12, 2021

The PowerDNS-Admin project provides a PowerDNS compatible API that's scoped to allow an API KEY to access only specific, authenticated domains.

The only change needed to support this in certbot-dns-powerdns, is to accept a few new responses when guessing the zone name.

This PR adds support for this, and have been tested with all (3) available access roles from PowerDNS-Admin (User, Operator, Administrator).

@tmuncks
Copy link
Author

tmuncks commented Oct 12, 2021

This is pretty much functionally identical to #10 but works for all API roles in PowerDNS-Admin

@tmuncks
Copy link
Author

tmuncks commented Oct 12, 2021

For some reason the build fails after pushing an update to README.md. This is most likely a false positive, but please let me know if you need anything to get this merged. :-)

@tmuncks tmuncks force-pushed the fix-powerdns-admin-api-usage branch from 80a9b4f to 19b142d Compare October 18, 2021 16:05
@tmuncks
Copy link
Author

tmuncks commented Oct 18, 2021

Updated the PR as I saw reverse proxy configurations changing the default gunicorn HTTP Status messages from eg. "FORBIDDEN" to "Forbidden" to better honor the RFCs. I have redone the check to use the status_code, which makes more sense since the textual representation is just another representation of the code anyway.

@tmuncks tmuncks force-pushed the fix-powerdns-admin-api-usage branch 2 times, most recently from 153cf17 to 59235e1 Compare October 20, 2021 13:44
@tmuncks tmuncks force-pushed the fix-powerdns-admin-api-usage branch from 59235e1 to a281298 Compare October 20, 2021 13:45
@michaelarnauts
Copy link

I can confirm that this change makes it work with the PowerDNS-Admin API. Thanks!

@Heshmatkhah
Copy link

Any Updates on this PR?

@komodin
Copy link

komodin commented Sep 27, 2023

Hi, we encountered the same error when using the PowerDNS Admin API and I'm glad to found that someone encountered the same issue.

It will be really amazing if someone from @pan-net-security could take a quick look and merge it.

Sorry for the mention but maybe @splashx @beli-sk @mbag @matusf can help us with this.

Thanks in advance!

@tmuncks
Copy link
Author

tmuncks commented Sep 27, 2023

FWIW, I'm still using the same code in production in several places, with no issue since this PR was created.

@komodin
Copy link

komodin commented Sep 27, 2023

I also know that we're able to manually build it or whatever, but as this project has the dns-powerdns name I think it will be nice to make it compatible with the tools that we use nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants