ISSUE-1902 Fix Template::is_up_to_date contract #1903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSUE-1902 CHANGES.rst ISSUE-1902 Add PR info to CHANGES.rst ISSUE-1902 Test
rwielk
force-pushed
the
ISSUE-1902/fix-template-is_up_to_date-contract
branch
from
e883598
to
0bcbad2
Compare
|
See discussion in #1902 for close reason. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1902
Template::_uptodate type hints get supporting implementation
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs. (Opted against any change since this just fixes already expected behaviour from my POV)pre-commithooks and fix any issues.pytestandtox, no tests failed.Please hint me on where and how you want a test to get implemented for this, did not see an obvious place. (Example test in regressions added, perhaps it's good enough...)