Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional test coverage for async rendering of native type templates #1807

Merged
merged 18 commits into from
Jul 10, 2024
Merged

Additional test coverage for async rendering of native type templates #1807

merged 18 commits into from
Jul 10, 2024

Conversation

jayaddison
Copy link
Contributor

@jayaddison jayaddison commented Feb 19, 2023 •
edited
Loading

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.
    • PYTHONPATH=src pytest tests/test_nativetypes.py

@jayaddison jayaddison changed the title Additional test coverage for #1511 Additional test coverage for async rendering of native type templates Feb 19, 2023
@jayaddison jayaddison mentioned this pull request Sep 23, 2023
Closed
davidism
davidism reviewed Jul 10, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
@jayaddison
Revert "Add CHANGES.rst entry"
1659885 
This reverts commit 8b52122.

Conflicts:
	CHANGES.rst
@davidism davidism merged commit f8323cf into pallets:main Jul 10, 2024
12 checks passed
@jayaddison
Copy link
Contributor Author

Thank you both!

@jayaddison jayaddison deleted the issue-1806/pr-1511-additional-test-coverage branch July 10, 2024 16:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidism davidism davidism left review comments

@graingert graingert graingert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing test coverage from pull request #1511?
3 participants
@jayaddison @graingert @davidism