Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to username_recovery #1057

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Minor changes to username_recovery #1057

merged 1 commit into from
Jan 8, 2025

Conversation

jwag956
Copy link
Collaborator

@jwag956 jwag956 commented Jan 7, 2025

  • username recovery is an independent feature - so it can exist w/o the recovery feature. Separate that out when initialiing blueprint

  • update docs around username, username_recovery
    @jamesejr

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (d24e376) to head (d79fa3d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          37       37           
  Lines        4857     4858    +1     
=======================================
+ Hits         4779     4780    +1     
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/features.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@jamesejr jamesejr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thank you! 🙏🏽

- username recovery is an independent feature - so it can exist w/o the recovery feature. Separate that out when initialiing blueprint

- update docs around username, username_recovery
@jwag956 jwag956 merged commit ff7cda1 into main Jan 8, 2025
21 checks passed
@jwag956 jwag956 deleted the chore8 branch January 8, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants