Fix Apply filter button show/hide
#2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This became permanent visibly after #2501 because jQuery's show/hide methods work toggle inline styles for `display: none`, but that PR switched over to the `d-none` class from bootstrap. This patch adds/removes the `d-none` class now. :w
This lookup doesn't work because it's doing a full "class equals" check, but the class is "btn btn-primary". Also, because the page doesn't refresh when individual filters are removed, if the "Reset filters" button is removed altogether then users have no way to "apply" the removal of all filters. So we actually need to keep this button around when the last filter is removed (it remains a probably-weird user interaction, but I'm maintaining that for now - not because it's good, but just to not change the existing behaviour)
samuelhwilliams
changed the title
Apply filter button show/hide
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This became permanent visibly after #2501 because jQuery's show/hide
methods work toggle inline styles for
display: none, but that PRswitched over to the
d-noneclass from bootstrap.This patch adds/removes the
d-noneclass now.Fixes #2520