Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused coveralls requirement #2516

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Sep 3, 2024

Added in:
bb93ee7 ("Test python 3.5, and use coveralls and pylint.", 2016-03-10)


Looks like it was added for use with Travis. If we want to use a similar service on GitHub then there are Actions available.

@cjmayo
Copy link
Contributor Author

cjmayo commented Sep 3, 2024

So, it's still in the txt files??? Are they not generated here?

@cjmayo cjmayo marked this pull request as draft September 3, 2024 18:38
@samuelhwilliams
Copy link
Contributor

They need to be regenerated (pip-compiled) locally, it's not automatic

@cjmayo
Copy link
Contributor Author

cjmayo commented Sep 4, 2024

I see the tox environment, but when in the top directory of a new clone I run tox -e update-requirements I'm getting:

update-requirements run-test: commands[0] | pip-compile build.in -q -U
Usage: pip-compile [OPTIONS] [SRC_FILES]...
Try 'pip-compile -h' for help.

Error: Invalid value for '[SRC_FILES]...': Path 'build.in' does not exist.

Ubuntu 20.04.

@samuelhwilliams
Copy link
Contributor

I think that's for a different purpose (but is also broken and needs fixing)

To pin new requirements - pip-compile <file> - which needs pip-tools available

Added in:
bb93ee7 ("Test python 3.5, and use coveralls and pylint.", 2016-03-10)
@cjmayo cjmayo marked this pull request as ready for review September 5, 2024 18:31
@cjmayo
Copy link
Contributor Author

cjmayo commented Sep 5, 2024

OK. That's fixed now.

@samuelhwilliams samuelhwilliams merged commit 43594c6 into pallets-eco:master Sep 6, 2024
11 checks passed
@cjmayo cjmayo deleted the coveralls branch September 6, 2024 18:33
@cjmayo
Copy link
Contributor Author

cjmayo commented Sep 10, 2024

update-requirements run-test: commands[0] | pip-compile build.in -q -U
Usage: pip-compile [OPTIONS] [SRC_FILES]...
Try 'pip-compile -h' for help.

Error: Invalid value for '[SRC_FILES]...': Path 'build.in' does not exist.

That's with Ubuntu 20.04's own tox-3.13, works fine with tox 4.18.1

@samuelhwilliams
Copy link
Contributor

samuelhwilliams commented Sep 10, 2024

Somewhat expected - that tox command uses change_dir which was only added in tox v4+.

Possibly dev.in could be updated to clarify this.

Also we possibly want another tox command - compile-requirements, which doesn't force update all of the packages. This for where we may just be adding a package to one or more of the .in files.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants