Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customising page_size options, and prevent arbitrary page sizes #2479

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Allow customising page_size options, and prevent arbitrary page sizes #2479

merged 2 commits into from
Jul 24, 2024

Conversation

samuelhwilliams
Copy link
Contributor

Makes two changes:

  • Prevents users from entering arbitrary values for page_size in the URL when can_set_page_size is True
  • Allows customising the page_size options available to users. The default is (20, 50, 100).

fixes: #2430
fixes: #2412

@samuelhwilliams samuelhwilliams mentioned this pull request Jul 24, 2024
Open
18 tasks
@samuelhwilliams samuelhwilliams marked this pull request as ready for review July 24, 2024 21:03
@samuelhwilliams samuelhwilliams merged commit 2cfe747 into master Jul 24, 2024
8 checks passed
@samuelhwilliams samuelhwilliams deleted the page-size branch July 24, 2024 21:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@samuelhwilliams