Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to add Pallets Ecosystem notice #2434

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Update readme to add Pallets Ecosystem notice #2434

merged 2 commits into from
Jun 30, 2024

Conversation

samuelhwilliams
Copy link
Contributor

@samuelhwilliams samuelhwilliams commented Jun 25, 2024

This commit converts the README from .rst to .md, and then adds the Pallets Community Ecosystem notice. I don't believe .rst files can show the same "Important" alert boxes and it feels correct to keep it visually consistent between projects.

I've also updated all of the references in the README from github.com/flask-admin/flask-admin to github.com/pallets-eco/flask-admin. I can add another commit that does the rest of the project's references, or I can remove that change from this PR to do it all references together in a separate PR.

This will allow us to add a consistency 'alert' panel for the Pallets
Ecosystem Notice.
@princerb
Copy link
Contributor

Is flask-admin not active anymore?

@Abdur-rahmaanJ
Copy link
Member

@princerb Just transferred to the Pallets!

@princerb
Copy link
Contributor

@princerb Just transferred to the Pallets!

I see, but I also can see the date when the last commit was made. So this repo is inactive for this too long, and 78+ open pull requests. For this reason, I am afraid I am not willing to open my pull request while I have some contribution improvements for the project.

@aenglander
Copy link
Contributor

setup.py still references README.rst for the package's long description.

@samuelhwilliams
Copy link
Contributor Author

@aenglander good spot - have fixed that reference (and the reference in MANIFEST.in as well)

setup.py Outdated Show resolved Hide resolved
@aenglander aenglander merged commit 7709a4d into pallets-eco:master Jun 30, 2024
7 checks passed
@Abdur-rahmaanJ
Copy link
Member

@princerb We actually need more maintainers. Feel free to join the Pallets discord # pallets-eco channel ^^.

@samuelhwilliams samuelhwilliams deleted the update-readme branch July 3, 2024 19:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants