Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest flask, sqlalchemy, flask-sqlalchemy and wtforms #2328

Closed
wants to merge 33 commits into from

Commits on Oct 19, 2023

  1. Drop unused requirements

    cjmayo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b5bc87c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53778e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa08f57 View commit details
    Browse the repository at this point in the history
  4. Rename tox-version to tox-env

    cjmayo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    734f660 View commit details
    Browse the repository at this point in the history
  5. Use Python 3.x for checks

    cjmayo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    44305b2 View commit details
    Browse the repository at this point in the history
  6. Drop WTForms test environments

    cjmayo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    323021d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c0f0c52 View commit details
    Browse the repository at this point in the history
  8. Set permissions on workflow

    cjmayo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6fac9ac View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a25bec9 View commit details
    Browse the repository at this point in the history
  10. Ensure Azure tests are not skipped

    flask_admin.contrib.fileadmin.azure uses the API of the 2.X SDK
    cjmayo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    8d60eee View commit details
    Browse the repository at this point in the history
  11. Test the minimum requirements

    With monogengine 0.19.1:
    error in mongoengine setup command: use_2to3 is invalid.
    
    jinja2 2.10.1 needed for flask 1.1.1
    
    itsdangerous==2.0.1 else:
    ImportError: cannot import name 'json' from 'itsdangerous'
    
    werkzeug else:
    ImportError: cannot import name 'BaseResponse' from 'werkzeug.wrappers'
    
    Minimum version of Pillow raised in:
    ecdc3e9 ("Require Pillow >= 9.1.0", 2023-10-15)
    cjmayo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f1945f3 View commit details
    Browse the repository at this point in the history
  12. flask-babelex requires pytz

    .tox/py/lib/python3.10/site-packages/flask_babelex/__init__.py:25: in <module>
        from pytz.gae import pytz
    E   ModuleNotFoundError: No module named 'pytz'
    cjmayo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    bdd45d1 View commit details
    Browse the repository at this point in the history
  13. Minimum version of sqlalchemy raised to 1.4

    By:
    11e828a ("Merge pull request pallets-eco#2340 from isolovey/deprecated-query-get", 2023-10-15)
    cjmayo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    2c7cd11 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    bf22d18 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    4b71c70 View commit details
    Browse the repository at this point in the history
  2. Fix register_blueprint AssertionError in tests

    "AssertionError: The setup method 'register_blueprint' can no longer be called on the application. It has already handled its first request, any changes will not be applied consistently. Make sure all imports, decorators, functions, etc. needed to set up the application are done before running it."
    Benjamin LECHA authored and cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f9330d8 View commit details
    Browse the repository at this point in the history
  3. Fix test_export_csv AssertionError

    FAILED tests/test_model.py::test_export_csv - AssertionError: assert 'Col1,Col2\r\..._3,col2_3\r\n' == 'Col1,Col2\r\...,–utf8_2–\r\n'
    Benjamin LECHA authored and cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    fe037b6 View commit details
    Browse the repository at this point in the history
  4. Fix test_different_bind_joins UnboundExecutionError

    sqlalchemy.exc.UnboundExecutionError: Bind key 'other' is not in 'SQLALCHEMY_BINDS' config.
    cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2c61488 View commit details
    Browse the repository at this point in the history
  5. Fix test_models AssertionError: assert None == ''

     >       assert model.test == ''
     E       AssertionError: assert None == ''
     E        +  where None = <Model test
    
    WTForms 3 changed StringField data default value.
    cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    bfe9947 View commit details
    Browse the repository at this point in the history
  6. Fix test_citext 'Engine' object has no attribute 'execute'

     >           db.engine.execute('CREATE EXTENSION IF NOT EXISTS citext')
     E           AttributeError: 'Engine' object has no attribute 'execute'
    cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a608123 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5d6da21 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b2cb244 View commit details
    Browse the repository at this point in the history
  9. Fix Exception: Cannot find reverse relation for model

    SQLAlchemy 2.0.2 removed the invocation of registry.configure() from
    Mapper.iterate_properties causing this problem.
    
    sqlalchemy.orm.registry.configure() was added in 1.4.0b2.
    
    Observed as test failures in:
    
    flask_admin/tests/sqla/test_basic.py
    flask_admin/tests/sqla/test_form_rules.py
    flask_admin/tests/sqla/test_inlineform.py
    cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2027135 View commit details
    Browse the repository at this point in the history
  10. Resolve LegacyAPIWarning for Query.get()

    LegacyAPIWarning: The Query.get() method is considered legacy as of the
    1.x series of SQLAlchemy and becomes a legacy construct in 2.0.
    The method is now available as Session.get() (deprecated since: 2.0)
    dgilman authored and cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f35f519 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    69c9b28 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b215278 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    c6d5f3e View commit details
    Browse the repository at this point in the history
  14. Exclude monoengine tests

    cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    291e75b View commit details
    Browse the repository at this point in the history
  15. sqlalchemy-utils CurrencyType needs Babel

    E           sqlalchemy_utils.exceptions.ImproperlyConfigured: 'babel' package is required in order to use CurrencyType.
    
    .tox/py/lib/python3.9/site-packages/sqlalchemy_utils/types/currency.py:55: ImproperlyConfigured
    cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    64fa2eb View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a3276d6 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    cf6c71c View commit details
    Browse the repository at this point in the history
  18. Fix test_safe_redirect after Werkzeug 2.3.0 updated safe chars

                assert rv.location.startswith(expected)
    >           assert 'url=http%3A%2F%2Flocalhost%2Fadmin%2Fmodel2view%2F' in rv.location
    E           AssertionError: assert 'url=http%3A%2F%2Flocalhost%2Fadmin%2Fmodel2view%2F' in '/admin/model1/edit/?id=1&url=http://localhost/admin/model2view/'
    E            +  where '/admin/model1/edit/?id=1&url=http://localhost/admin/model2view/' = <WrapperTestResponse streamed [302 FOUND]>.location
    
    flask_admin/tests/sqla/test_basic.py:2466: AssertionError
    cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    eb0ce69 View commit details
    Browse the repository at this point in the history
  19. Exclude wtf-peewee 3.0.5

    cjmayo committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    def21a9 View commit details
    Browse the repository at this point in the history