Skip to content

Commit

Permalink
Pin wtf-peewee 3.0.4
Browse files Browse the repository at this point in the history 
With WTForms 3.1.2 and wtf-peewee 3.0.5:

__________________________ test_column_editable_list ___________________________
flask_admin/tests/peeweemodel/test_basic.py:247: in test_column_editable_list
    assert 'test1_val_3' in data
E   AssertionError: assert 'test1_val_3' in '<!doctype html>\n<html lang=en>\n<title>500 Internal Server Error</title>\n<h1>Internal Server Error</h1>\n<p>The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.</p>\n'

------------------------------ Captured log call -------------------------------
ERROR    flask_admin.tests.conftest:app.py:838 Exception on /admin/model1/ajax/update/ [POST]
Traceback (most recent call last):
  File "/home/runner/work/flask-admin/flask-admin/.tox/py312-flask3-wtforms3/lib/python3.12/site-packages/peewee.py", line 7285, in get
    return clone.execute(database)[0]
           ~~~~~~~~~~~~~~~~~~~~~~~^^^
 ...

File "/home/runner/work/flask-admin/flask-admin/.tox/py312-flask3-wtforms3/lib/python3.12/site-packages/wtfpeewee/fields.py", line 261, in __call__
    return self.widget(self, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/flask-admin/flask-admin/flask_admin/model/widgets.py", line 98, in __call__
    kwargs = self.get_kwargs(field, kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/flask-admin/flask-admin/flask_admin/model/widgets.py", line 161, in get_kwargs
    for value, label, selected in field.iter_choices():
        ^^^^^^^^^^^^^^^^^^^^^^
ValueError: too many values to unpack (expected 3)
  • Loading branch information
@cjmayo
cjmayo committed Jul 30, 2024
1 parent 9f6eee8 commit f0ddab8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ mongoengine = [ # TODO: seems out-of-date/unmaintained; replace or deprecate?
pymongo = ["pymongo>=3.7.0"]
peewee = [
"peewee>=3.14.0",
"wtf-peewee>=3.0.4"
"wtf-peewee==3.0.4"
]
s3 = ["boto"] # TODO: migrate to boto3
azure-blob-storage = ["azure-storage-blob<=3"] # TODO: update to v12+
Expand Down

0 comments on commit f0ddab8

Please sign in to comment.