Update ETL scripts to support mysql-v8.0 #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojwanganto
requested changes
Jun 16, 2023
| @@ -69,13 +69,13 @@ | |||
| <changeSet id="${project.parent.artifactId}-20171212-1744" author="aojwang"> | |||
| <preConditions onFail="MARK_RAN"> | |||
| <sqlCheck expectedResult="0"> | |||
| SELECT COUNT(*) FROM scheduler_task_config | |||
| SELECT COUNT(*) FROM openmrs.scheduler_task_config | |||
There was a problem hiding this comment.
we usually don't do this so that there is flexibility in naming the database. there are people who prefer not to call their openmrs dbs as openmrs.
There was a problem hiding this comment.
This is noted. I'll try to find out then why the application was trying to read the table for kenyaemr_etl db instead of production table
| @@ -135,7 +135,7 @@ marital_status VARCHAR(50) DEFAULT NULL, | |||
| education_level VARCHAR(50) DEFAULT NULL, | |||
| kdod_service_number VARCHAR(50) DEFAULT NULL, | |||
| cadre VARCHAR(100) DEFAULT NULL, | |||
| rank VARCHAR(100) DEFAULT NULL, | |||
| kdod_rank VARCHAR(100) DEFAULT NULL, | |||
There was a problem hiding this comment.
is this a migration issue? Has the change cascaded in the reports?
There was a problem hiding this comment.
btw, is rank a reserved name in mysql 8?
There was a problem hiding this comment.
Yes rank is a reserved word in the new version, that's why I had to rename the column. And yes I will cascade these changes to the reports as well
jecihjoy
force-pushed
the
mysql-v8.0-upgrade
branch
from
e597b98 to
c3651c7
Compare
makombe
force-pushed
the
openmrs-2.6.x-upgrade
branch
from
91631ee to
d087825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.