Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor): KHP3 Add Dynamic Attribute Handling and enhance "Sync" & "Edit" Functionalities for Providers #565

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

(refactor): KHP3 Add Dynamic Attribute Handling and enhance "Sync" & "Edit" Functionalities for Providers #565

wants to merge 3 commits into from

Conversation

its-kios09
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

The button is enabled only if at least one of the following provider attributes has a value:

  • National ID (providerNationalId)
  • Passport Number (passPortNumber)
  • Registration Number (registrationNumber)

Dynamic Provider Payload Construction:

  • Attributes in the providerPayload are added only if the corresponding data fields are provided. And new attributes are created only if their values are not null or undefined.

Screenshots

syncandeift

None.

Related Issue

None.

Other

None.

Omoshlawi
Omoshlawi requested changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@Omoshlawi Omoshlawi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank @its-kios09 , seems good except for the small issues on translations

packages/esm-providers-app/src/workspace/provider-form.workspace.tsx Outdated Show resolved Hide resolved
packages/esm-providers-app/src/workspace/provider-form.workspace.tsx Outdated Show resolved Hide resolved
packages/esm-providers-app/src/workspace/provider-form.workspace.tsx Outdated Show resolved Hide resolved
@its-kios09
Copy link
Collaborator Author

ping @donaldkibet @Omoshlawi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Omoshlawi Omoshlawi Awaiting requested review from Omoshlawi

@donaldkibet donaldkibet Awaiting requested review from donaldkibet

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@its-kios09 @donaldkibet @Omoshlawi