grouped radiology orders by patient #88
Conversation
There was a problem hiding this comment.
Thanks @FelixKiprotich350 for this work. cc @ojwanganto looking at these designs should we align our work to this pattern for clinical management works e.g procedures, imaging, labs and billing see
| currentPage, | ||
| } = usePagination(searchResults, currentPageSize); | ||
|
|
||
| const pageSizes = [10, 20, 30, 40, 50]; |
There was a problem hiding this comment.
we have a hook to generate page sizes usePaginationInfo from @openmrs/esm-framework
There was a problem hiding this comment.
@donaldkibet i am done with your comments but this seem unclear to me. any help on implementing this usePaginationInfo, the parameters are kinda confusing to me and cant find a similar implementation. Thanks
| background-color: #fff; | ||
| border-left: 4px solid var(--brand-03); | ||
| color: $text-02; | ||
| margin-bottom: 1rem !important; |
There was a problem hiding this comment.
| margin-bottom: 1rem !important; | |
| margin-bottom: 1rem !important; |
if possible using !important should be the last options
|
@donaldkibet , @makombe and @ojwanganto Your suggestions are effected you can review |
|
@FelixKiprotich350 - please remember to update the attached video/screenshots |
|
@ojwanganto latest screen record of the interface updated on the PR |
|
Thanks so much |
|
Can we have this in? |
|
Am working on the updates
…On Tue, Jul 30, 2024, 2:07 PM ojwanganto ***@***.***> wrote:
Can we have this in?
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARGPKMEAZGCID73NUGURVODZO5XXNAVCNFSM6AAAAABLR2HOOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYGA4DQMZVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@FelixKiprotich350 merge this in once you are done with the updates |
|
Ok, I will do it.
…On Tue, Jul 30, 2024, 3:02 PM Donald Kibet ***@***.***> wrote:
@FelixKiprotich350 <https://github.com/FelixKiprotich350> merge this in
once you are done with the updates
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARGPKMEKMBBY4AIAU72WT3DZO56EHAVCNFSM6AAAAABLR2HOOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYGE4DEMBZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
hello @donaldkibet am realizing that this PR is on radiology yet i was responding in the context of procedure module, so i think this is good to go and you can merge, if in case ill have to make any addition ill just open another PR |
|
Thanks, @FelixKiprotich350 |
Requirements
For changes to apps
If applicable
Summary
in this PR i have improved the radiology module by grouping the orders by patient, and using an accordion list all orders alongside their actions.
Created a Grouping component reused across all the tabs.
I have also updated the accordion buttons and ensured that the reject button is always the last does not (precede button like report and pick request)
Screenshots
earlier UI look
screen-capture.webm
latest UI look
screen-capture-latest.webm
Related Issue
Other