Remove hard coded empty complictions key injected in results payload #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
requested changes
Jun 10, 2024
There was a problem hiding this comment.
Thanks @makombe, Is there logic to save complication as obs, I think we should resolve this on PR
|
As from discussion with @makombe this seems a case of carrying over code that initially implemented procedures. Merging this in. |
donaldkibet
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This key is what is failing due to the redesign and looking at the code it does not do much in result form. It is just hard coded in the payload. Dropping it for now and be aligned later appropriately
Screenshots
Related Issue
Other