moved the ODS.Dim.All_EMRSites to ODS.Care.All_EMRSites

[DennisGibz]

Summary by Sourcery

Chores:

• Move the All_EMRSites table from the ODS.Dim schema to the ODS.Care schema.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request moves the All_EMRSites table from the ODS.Dim schema to the ODS.Care schema. The SDP_Agency column in the All_EMRSites table is also altered to nvarchar(4000).

ER diagram showing the schema change for All_EMRSites table

erDiagram
    ODS_Dim_All_EMRSites ||--o{ ODS_Care_All_EMRSites : "moved to"
    ODS_Dim_All_EMRSites {
        nvarchar SDP_Agency
    }
    ODS_Care_All_EMRSites {
        nvarchar(4000) SDP_Agency
    }
    note for ODS_Dim_All_EMRSites "Old schema location"
    note for ODS_Care_All_EMRSites "New schema location with modified column size"

Loading

File-Level Changes

Change	Details	Files
Moved the All_EMRSites table from ODS.Dim to ODS.Care.	Changed the schema of the All_EMRSites table from ODS.Dim to ODS.Care. Updated the ALTER TABLE statement to reflect the new schema location of the All_EMRSites table	Scripts/NDWH/C&T FACT TABLES/load_FactLatestObs.sql
Altered the SDP_Agency column in the All_EMRSites table to nvarchar(4000).	Modified the data type of the SDP_Agency column to nvarchar(4000).	Scripts/NDWH/C&T FACT TABLES/load_FactLatestObs.sql

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @DennisGibz - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please document the reason for moving the table from ODS.Dim to ODS.Care schema. Schema changes should include justification in the PR description.
• Have all dependencies (views, stored procedures, etc.) that reference ODS.Dim.All_EMRSites been identified and updated? Please confirm impact analysis has been completed.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}