Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using callable objects as scopes #261 #263

Merged
merged 4 commits into from
May 22, 2024
Merged

Allow using callable objects as scopes #261 #263

merged 4 commits into from
May 22, 2024

Conversation

killondark
Copy link
Contributor

Hi @palkan. Please check my PR by issue #261

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented May 7, 2024 •
edited
Loading

Coverage Status

coverage: 93.693% (+0.07%) from 93.628%
when pulling 8799fa4 on killondark:add-callable-object-as-scope
into c84335b on palkan:master.

@killondark
Copy link
Contributor Author

@palkan, up.

palkan
palkan requested changes May 21, 2024
View reviewed changes
Copy link
Owner

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

But no tests—how so?

@killondark
Copy link
Contributor Author

Hi @palkan. I wrote tests, fixed logic and updated documentation.

palkan
palkan approved these changes May 22, 2024
View reviewed changes
Copy link
Owner

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@palkan palkan merged commit 2f14a9c into palkan:master May 22, 2024
12 checks passed
@palkan palkan mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palkan palkan palkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killondark @palkan