Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break things (followup from #166) #168

Merged
merged 3 commits into from
Feb 20, 2018

Conversation

nordfjord
Copy link
Collaborator

@nordfjord nordfjord commented Feb 1, 2018

This will resolve #167

And remove the functionality deprecated by #166

this means

  1. flatMap is no longer available as a module (use flyd.chain instead)
  2. Promise swallowing is removed

@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling f3a899b on nordfjord:remove-promise-swallowing into 082cc86 on paldepind:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a1bc431 on nordfjord:remove-promise-swallowing into 3afb73a on paldepind:master.

@nordfjord nordfjord mentioned this pull request Feb 1, 2018
3 tasks
@nordfjord nordfjord force-pushed the remove-promise-swallowing branch from a1bc431 to 3604505 Compare February 1, 2018 21:21
@nordfjord nordfjord force-pushed the remove-promise-swallowing branch from 3604505 to d3c0dc7 Compare February 12, 2018 23:40
@nordfjord nordfjord changed the title Remove Promise swallowing Break things (followup from #166) Feb 12, 2018
@nordfjord
Copy link
Collaborator Author

@paldepind Are you ready to break things?

@StreetStrider
Copy link
Contributor

Time for v0.3.

@c-dante
Copy link
Contributor

c-dante commented Feb 13, 2018

Does this mean we can also remove #37?

@paldepind
Copy link
Owner

@nordfjord I'm ready 😄 I'll take a good look this weekend!

@paldepind
Copy link
Owner

This looks good to me 🎉

@paldepind paldepind merged commit fb2124f into paldepind:master Feb 20, 2018
@paldepind
Copy link
Owner

@StreetStrider

Time for v0.3.

What about releasing this as v1.0.0?

@StreetStrider
Copy link
Contributor

StreetStrider commented Feb 20, 2018

@paldepind If you ask my opinion, I would like we all to investigate end stream related issues, mostly #116 and cast @c-dante @nordfjord, and think about how to signalize errors as well. #35 #164

I also wanted to pull up an deferred emitting discussion, but havent enough «meat» to start that discussion. You see, when you do Promise.resolve(17).then(…) execution is asynchronous (even in example, where result is already in). I think observable libary should follow that behavior for better guarantees for programmer, but flyd is special in that way and very-very synchronous by its nature. This is a topic for another discussion.

Last several months I was developing some build system, where flyd plays the same role that node streams plays in gulp. I'm ok with flyd, but I was forced to solve some very specific tasks, like async stream resolving, promise—stream, stream—promise bridges, value caching/backpessure. Some of them are definitely outside flyd's scope, but due solving them I was thinking that flyd is not ready for v1 yet, and I personally would love some time for changes to occur before things become more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A case against Promise swallowing
5 participants