Add TURN support #59
Merged
Add TURN support #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs testing together with palavatv/signaltower#30 and palavatv/palava-client#30. |
This was referenced Jun 20, 2020
farao
force-pushed
the
turn
branch
2 times, most recently
from
69e62d4
to
8e49519
Compare
The TURN server url can be set via environment variable VUE_APP_TURN_URL.
|
Awesome to see this finally being tackled! |
janlelis
approved these changes
Jun 21, 2020
|
@farao Looks good, and I just wanted to merge, however one thing just came to my mind: How should (or would) we configure multiple TURN servers? |
|
Let's tackle multiple TURN servers in a future PR to not let this get too large, ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TURN server url can be set via environment variable VUE_APP_TURN_URL.