Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "ideal" video resolution values #50

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Conversation

janlelis
Copy link
Member

- Implements #47
- Default aspect ratio is now 16:9
- Not setting too high to save bandwidth
- See https://stackoverflow.com/a/28911694/169793
@janlelis
Copy link
Member Author

Full configurable user media would be awesome, see #49 for this

@farao
Copy link
Member

farao commented Jun 1, 2020

The github link sais that this will work in chrome only when using adapter.js - but without adapter.js, getusermedia will still work, only the constraints not understood?

@janlelis
Copy link
Member Author

janlelis commented Jun 2, 2020

The github link sais that this will work in chrome only when using adapter.js - but without adapter.js, getusermedia will still work, only the constraints not understood?

That's my understanding, too. Anyways, since we use the adapter.js polyfills, we should be good.

@farao farao merged commit 70af924 into master Jun 2, 2020
@farao farao deleted the feature/set-ideal-gum-values branch June 2, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants