Support option for plaintext servers on loopback addresses #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Witchcraft currently doesn't support creating a non-TLS server. We very rarely need this functionality, but when we do, we need to copy a non-trivial amount of code to get things like telemetry middleware to work. Witchcraft could attempt to support those use cases by allowing the creation of a plaintext server in specific scenarios where TLS is less important (usually a
localhostor perhaps a UNIX socket).After this PR
==COMMIT_MSG==
Support option for plaintext servers on loopback addresses
==COMMIT_MSG==
Possible downsides?
Would be totally reasonable to say this is something we shouldn't support and should instead work to make the witchcraft middleware more consumable for "wrouter, but not witchcraft" use cases.
This change is