Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CaffeineCacheStats.registerCache #2003

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-2003.v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Deprecate CaffeineCacheStats.registerCache
links:
- https://github.com/palantir/tritium/pull/2003
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ public static void registerCache(MetricRegistry registry, Cache<?, ?> cache, Str
* @param cache cache to instrument
* @param name cache name
* <p>
* Soon to be deprecated, prefer {@link Caffeine#recordStats(Supplier)} and {@link CacheStats#of(TaggedMetricRegistry, String)}
* @deprecated Prefer {@link Caffeine#recordStats(Supplier)} and {@link CacheStats#of(TaggedMetricRegistry, String)}
ash211 marked this conversation as resolved.
Show resolved Hide resolved
*/
// Soon to be @Deprecated
@Deprecated
public static void registerCache(TaggedMetricRegistry registry, Cache<?, ?> cache, @Safe String name) {
checkNotNull(registry, "registry");
checkNotNull(cache, "cache");
Expand Down