Skip to content

[PJF] Do not reflow text blocks #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mitchjust
Copy link

Adds upstream fix google/google-java-format@295e7a4

Before this PR

Formatting a textblock which

  • exceeds the max line length
  • has no trailing newline (ie. """ is at the end of the line)

Causes the formatter to fail:

error: Something has gone terribly wrong. Please file a bug: https://github.com/palantir/palantir-java-format/issues/new

=== Actual: ===
package com.test;

public class MyTest {
    private String myString = "A very long string which just so happens to exceed the max line length and doesn't\"\n    + \" have a trailing newline";
}
=== Expected: ===
package com.test;

public class MyTest {
    private String myString = "A very long string which just so happens to exceed the max line length and doesn't have a trailing newline";
}

After this PR

Formatter doesn't fail, Fixes #1205

==COMMIT_MSG==
==COMMIT_MSG==

Possible downsides?

@palantirtech
Copy link
Member

Thanks for your interest in palantir/palantir-java-format, @mitchjust! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Apr 24, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

[PJF] Do not reflow text blocks

Check the box to generate changelog(s)

  • Generate changelog entry

@mitchjust
Copy link
Author

@crogoz sorry for the direct ping, could I get a review on this when you get a chance? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when formatting text blocks with the command-line tool
3 participants