-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demonstration] Working Conjure compiler graal native-image #780
Draft
carterkozak
wants to merge
4
commits into
master
Choose a base branch
from
ckozak/graal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"resources": { | ||
"includes": [ | ||
{"pattern": "^(.(?!.*\\.class))*$"} | ||
] | ||
} | ||
} |
126 changes: 126 additions & 0 deletions
126
conjure/src/main/java/com/palantir/conjure/cli/RuntimeReflectionRegistrationFeature.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,126 @@ | ||
/* | ||
* (c) Copyright 2021 Palantir Technologies Inc. All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.palantir.conjure.cli; | ||
|
||
import java.io.IOException; | ||
import java.lang.reflect.AnnotatedElement; | ||
import java.nio.file.Path; | ||
import java.util.ArrayList; | ||
import java.util.Enumeration; | ||
import java.util.HashMap; | ||
import java.util.HashSet; | ||
import java.util.LinkedHashMap; | ||
import java.util.LinkedList; | ||
import java.util.concurrent.ConcurrentHashMap; | ||
import java.util.jar.JarEntry; | ||
import java.util.jar.JarFile; | ||
import org.graalvm.nativeimage.Platform; | ||
import org.graalvm.nativeimage.Platforms; | ||
import org.graalvm.nativeimage.hosted.Feature; | ||
import org.graalvm.nativeimage.hosted.RuntimeReflection; | ||
|
||
@SuppressWarnings({"CatchAndPrintStackTrace", "JdkObsolete"}) | ||
@Platforms(Platform.HOSTED_ONLY.class) | ||
final class RuntimeReflectionRegistrationFeature implements Feature { | ||
|
||
@Override | ||
public void beforeAnalysis(BeforeAnalysisAccess access) { | ||
// Common standard library classes | ||
registerClassForReflection(String.class); | ||
registerClassForReflection(HashSet.class); | ||
registerClassForReflection(HashMap.class); | ||
registerClassForReflection(LinkedHashMap.class); | ||
registerClassForReflection(ArrayList.class); | ||
registerClassForReflection(LinkedList.class); | ||
registerClassForReflection(ConcurrentHashMap.class); | ||
for (Path jarPath : access.getApplicationClassPath()) { | ||
String jarFileName = jarPath.getFileName().toString(); | ||
if (!jarFileName.endsWith(".jar")) { | ||
// Only scan jars | ||
continue; | ||
} | ||
try (JarFile jar = new JarFile(jarPath.toFile())) { | ||
Enumeration<JarEntry> entries = jar.entries(); | ||
while (entries.hasMoreElements()) { | ||
JarEntry entry = entries.nextElement(); | ||
String name = entry.getName(); | ||
if (name.endsWith(".class") | ||
// Exclude multirelease files, the default jvm version class name is sufficient. | ||
&& !name.startsWith("META-INF") | ||
// Exclude graal components | ||
&& !name.contains("com/oracle/svm") | ||
// Includes incorrect repackaging with malformed signatures. These break the build. | ||
&& !name.contains("repackaged") | ||
&& !name.contains("shaded") | ||
&& !name.contains("glassfish") | ||
&& !name.startsWith("javax") | ||
&& !name.startsWith("jakarta")) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was whac-a-mole. |
||
String className = name.replace("/", ".").substring(0, name.length() - 6); | ||
try { | ||
registerClassForReflection(access.findClassByName(className)); | ||
} catch (Throwable t) { | ||
t.printStackTrace(); | ||
} | ||
} | ||
} | ||
} catch (IOException | RuntimeException e) { | ||
e.printStackTrace(); | ||
} | ||
} | ||
} | ||
|
||
private static void registerClassForReflection(Class<?> clazz) { | ||
if (clazz != null) { | ||
try { | ||
if (!isAnyElementGraalAnnotated(clazz)) { | ||
RuntimeReflection.register(clazz); | ||
RuntimeReflection.register(clazz.getDeclaredMethods()); | ||
RuntimeReflection.register(clazz.getDeclaredConstructors()); | ||
RuntimeReflection.register(clazz.getDeclaredFields()); | ||
} | ||
} catch (NoClassDefFoundError e) { | ||
System.err.printf("NoClassDefFoundError: %s While inspecting %s\n", e.getMessage(), clazz.getName()); | ||
} catch (Throwable t) { | ||
t.printStackTrace(); | ||
// ignored | ||
} | ||
} | ||
} | ||
|
||
private static boolean isAnyElementGraalAnnotated(Class<?> clazz) { | ||
try { | ||
return isGraalAnnotated(clazz) | ||
|| isAnyGraalAnnotated(clazz.getDeclaredMethods()) | ||
|| isAnyGraalAnnotated(clazz.getDeclaredConstructors()) | ||
|| isAnyGraalAnnotated(clazz.getDeclaredFields()); | ||
} catch (Throwable t) { | ||
return false; | ||
} | ||
} | ||
|
||
private static boolean isAnyGraalAnnotated(AnnotatedElement[] elements) { | ||
for (AnnotatedElement element : elements) { | ||
if (isGraalAnnotated(element)) { | ||
return true; | ||
} | ||
} | ||
return false; | ||
} | ||
|
||
private static boolean isGraalAnnotated(AnnotatedElement element) { | ||
return element.isAnnotationPresent(Platforms.class); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear if the
.class
extension exclusion is necessary, I was debugging other things.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an ideal world we'd be able to do this programatically using a build Feature like reflection to reduce dependence on custom configs.