Singleton beans use a JsonCreator with mode=PROPERTIES (#2351)

Singleton beans use a JsonCreator with mode=PROPERTIES
palantir · Sep 5, 2024 · 6426718 · 6426718
1 parent 19d7f54
commit 6426718
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/changelog/@unreleased/pr-2351.v2.yml b/changelog/@unreleased/pr-2351.v2.yml
@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: Singleton beans use a JsonCreator with mode=PROPERTIES
+  links:
+  - https://github.com/palantir/conjure-java/pull/2351
diff --git a/conjure-java-core/src/integrationInput/java/com/palantir/product/EmptyObjectExample.java b/conjure-java-core/src/integrationInput/java/com/palantir/product/EmptyObjectExample.java
diff --git a/conjure-java-core/src/integrationInput/java/com/palantir/strict/EmptyObjectNotStrict.java b/conjure-java-core/src/integrationInput/java/com/palantir/strict/EmptyObjectNotStrict.java
diff --git a/...a-core/src/integrationInput/java/test/prefix/com/palantir/product/EmptyObjectExample.java b/...a-core/src/integrationInput/java/test/prefix/com/palantir/product/EmptyObjectExample.java
diff --git a/conjure-java-core/src/main/java/com/palantir/conjure/java/types/BeanGenerator.java b/conjure-java-core/src/main/java/com/palantir/conjure/java/types/BeanGenerator.java
@@ -405,7 +405,7 @@ private static MethodSpec createStaticFactoryMethodForEmptyBean(ClassName object
         return MethodSpec.methodBuilder("of")
                 .addModifiers(Modifier.PUBLIC, Modifier.STATIC)
                 .returns(objectClass)
-                .addAnnotation(ConjureAnnotations.delegatingJsonCreator())
+                .addAnnotation(ConjureAnnotations.propertiesJsonCreator())
                 .addCode("return $L;", SINGLETON_INSTANCE_NAME)
                 .build();
     }