Fix: Cleanup jackson version overrides #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansanduleac
changed the title
dansanduleac
changed the title
carterkozak
reviewed
Nov 21, 2019
| com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.9.9 (3 constraints: 4a200b23) | ||
| com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.9.9 (2 constraints: a0134956) | ||
| com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.10.1 (3 constraints: 6a20e231) | ||
| com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.10.1 (2 constraints: c0138060) | ||
| com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:2.10.1 (2 constraints: d12e2568) |
carterkozak
approved these changes
Nov 21, 2019
dansanduleac
approved these changes
Nov 21, 2019
| @@ -1,17 +1,6 @@ | |||
| ch.qos.logback:logback-classic = 1.1.7 | |||
| # catch-all jackson version | |||
| com.fasterxml.jackson.*:jackson-* = 2.10.1 | |||
| # individual components are sometimes updated out of band to fix vulnerabilities | |||
There was a problem hiding this comment.
For future reference, a star constraint like the above will handle these hotfix releases just fine as well.
As in, it will try to find the given version for all components, but will fall back to the highest constrained version (of a bottom lib like jackson-databind) if the requested version doesn't exist.
In fact jackson itself features in gradle's integration tests for this feature:
https://github.com/gradle/gradle/blob/5d5c27d35e276d674da9a28a4af972d79589b78d/subprojects/dependency-management/src/integTest/groovy/org/gradle/integtests/resolve/alignment/AlignmentIntegrationTest.groovy#L241-L292
robert3005
commented
Nov 21, 2019
| @@ -104,6 +104,7 @@ public static ObjectMapper withDefaultModules(ObjectMapper mapper) { | |||
| .registerModule(new JavaTimeModule()) | |||
| .registerModule(new LenientLongModule()) | |||
| .disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS) | |||
| .disable(SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS) | |||
There was a problem hiding this comment.
For those curious FasterXML/jackson-modules-java8#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We had a bunch of specific jackson versions
After this PR
==COMMIT_MSG==
Consistently specify jackson version as 2.10.1
==COMMIT_MSG==
Possible downsides?
we already picked up 2.10.1 and this is just a cleanup that could prevent issues in future