fix: Force import alias when package ends in /v[0-9]+$ #409
Conversation
There was a problem hiding this comment.
Thanks, this looks great!
The other scenario that seems to be special-cased in the Go code is packages that start with go-, but I don't think that's a concern/case that we need to handle for Conjure since I'm not sure that packages are allowed to have a hyphen in the name (and even if they do, we probably have some safety from a practical perspective in that such package names should likely be rare).
| @@ -129,3 +134,7 @@ func newGoFile(filePath string, file *jen.File) *OutputFile { | |||
| file: file, | |||
| } | |||
| } | |||
|
|
|||
| func packageSuffixRequiresAlias(importPath string) bool { | |||
| return regexp.MustCompile(`/v[0-9]+$`).MatchString(importPath) | |||
There was a problem hiding this comment.
This looks great, thanks! The implementation the Go team uses for this is at https://github.com/palantir/go-ptimports/blob/93cb0022ccc2ca0a21b3ac3396b85349567cc40a/vendor/golang.org/x/tools/internal/imports/fix.go#L1145-L1153, but I think this regexp matching is more readable and fine.
|
Released 6.38.0 |
This is a more targetted fix for #405 than #406 reverted in #408.
Rather than operate on the generated files, we predict invalid package names and force an import alias. I've added a second test type to demonstrate how jennifer deconflicts aliases.
This change is