Fix Obsolete Warning & More #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet cleanup, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a follow up to #181 by updating the runner image to Ubuntu 24.04, but then it spiraled a bit into different directions. If you prefer, I can also split them into separate PRs.
I noticed that all the builds and tests were done in Debug mode. I'm not sure if this was intentional, but I've switched to Release mode. Additionally, I've noticed that both the Jab.FunctionalTest and Jab.FunctionalTest.MEDI had their Release mode configured back to Debug in the Jab solution.
The CI was throwing some obsolete warnings regarding XUnitVerifier pointing to the following documentation on how to fix it. https://github.com/dotnet/roslyn-sdk/blob/main/src/Microsoft.CodeAnalysis.Testing/README.md#obsolete-packages
The Jab.Attributes NuGet package complained about missing a README file, so I added the Jab one and a license expression, similar to the other NuGet package.
And finally I noticed a typo in the
eng/FunctionaTests.projfilename