Improve error logging

paketo-community · Sep 10, 2024 · 143ecb1 · 143ecb1
1 parent 1f190f8
commit 143ecb1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/generate_configuration_parser.go b/generate_configuration_parser.go
@@ -1,6 +1,7 @@
 package gogenerate
 
 import (
+	"fmt"
 	"os"
 
 	"github.com/mattn/go-shellwords"
@@ -33,15 +34,15 @@ func (p GenerateConfigurationParser) Parse() (GenerateConfiguration, error) {
 		generateConfiguration.Args, err = shellwordsParser.Parse(val)
 
 		if err != nil {
-			return GenerateConfiguration{}, err
+			return GenerateConfiguration{}, fmt.Errorf("BP_GO_GENERATE_ARGS=%q: %w", val, err)
 		}
 	}
 
 	if val, ok := os.LookupEnv("BP_GO_GENERATE_FLAGS"); ok {
 		generateConfiguration.Flags, err = shellwordsParser.Parse(val)
 
 		if err != nil {
-			return GenerateConfiguration{}, err
+			return GenerateConfiguration{}, fmt.Errorf("BP_GO_GENERATE_FLAGS=%q: %w", val, err)
 		}
 	}
 	return generateConfiguration, nil

diff --git a/generate_configuration_parser_test.go b/generate_configuration_parser_test.go
@@ -77,7 +77,7 @@ func testGenerateConfigurationParser(t *testing.T, context spec.G, it spec.S) {
 
 			it("returns an error", func() {
 				_, err := parser.Parse()
-				Expect(err).To(MatchError(ContainSubstring("invalid command line string")))
+				Expect(err).To(MatchError(ContainSubstring(`BP_GO_GENERATE_ARGS="\"": invalid command line string`)))
 			})
 
 			it.After(func() {
@@ -92,7 +92,7 @@ func testGenerateConfigurationParser(t *testing.T, context spec.G, it spec.S) {
 
 			it("returns an error", func() {
 				_, err := parser.Parse()
-				Expect(err).To(MatchError(ContainSubstring("invalid command line string")))
+				Expect(err).To(MatchError(ContainSubstring(`BP_GO_GENERATE_FLAGS="\"": invalid command line string`)))
 			})
 
 			it.After(func() {