Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit #107

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Initial commit #107

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d368e6
Initial commit
Jul 2, 2018
8b8ca99
Finished get letter grade
Jul 2, 2018
74af948
Finished The shortest string
Jul 2, 2018
247ab03
Updated and refactored based on comments. Much cleaner.
Jul 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions letsdrill.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,34 @@
def get_letter_grade(integer)

#Put your code here!

letter_grade = ""
if integer >= 90
letter_grade = "A"
elsif integer >= 80
letter_grade = "B"
elsif integer >= 70
letter_grade = "C"
elsif integer >= 60
letter_grade = "D"
else
letter_grade = "F"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole if/elsif/else structure evaluates to the value of whichever branch it takes. So, you could move the local variable assignment out of each condition like so:

letter_grade = if integer >= 90
                 "A"
               elsif ...

end
return letter_grade
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return keyword is optional in ruby, and the standard is to omit it. If you did that here, can you see how you could also get rid of the letter_grade variable?

end

def shortest_string(array)
return the_shortest_string = array.min_by{|a| a.size}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comments to the above apply here to. But nice use of min_by!


#Put your code here!

end



### Don't touch anything below this line ###

p "Fetch Letter Grade: You should have 2 trues"
p get_letter_grade(89) == "B"
p get_letter_grade(73) == "C"
p get_letter_grade(89) == "B"
p get_letter_grade(73) == "C"
p
p "Shortest String: You should have 3 trues"
p shortest_string(["touch","this", "car"]) == "car"
p shortest_string([]) == nil
p shortest_string(["can", "a", "solve", "Find", "solution"]) == "a"
p shortest_string([]) == nil
p shortest_string(["can", "a", "solve", "Find", "solution"]) == "a"