Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete challenge #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Complete challenge #43

wants to merge 1 commit into from

Conversation

lnestor
Copy link

@lnestor lnestor commented May 11, 2018

@jaybobo

Some answers to the questions asked in the scenario:

  • Authentication problems including being able to login with no username/password, being able to add "/dashboard" to the url to bypassing logging in

jaybobo
jaybobo reviewed May 15, 2018
View reviewed changes
features/login.feature
@@ -7,4 +7,9 @@ Feature: Login Page
Given the login page
When I log in with proper credentials
Then I should see the secret page


Scenario: Unauthenticated User
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition!

@jaybobo
Copy link
Member

jaybobo commented May 15, 2018

LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaybobo jaybobo jaybobo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lnestor @jaybobo