Wade branch #16
Open
Wade branch #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added two more commits for the other parts. |
| ActiveRecord::Schema.define(version: 0) do | ||
|
|
||
| create_table "urls", force: true do |t| | ||
| t.string "linkid", limit: UrlsHelper::LINKID_LENGTH, null: false |
There was a problem hiding this comment.
Was this created by a migration? If not, please read the comment at the top of this file for some guidance.
There was a problem hiding this comment.
I normally don't use code generators/wizards until I understand them. I spent a fair amount of time working to understand this and then did not go back to the migrations.
I will correct that in a new pull request.
added 3 commits
October 12, 2015 08:18
Instead of creating by hand, I used rails generate to build the initial model.
After a challenge from Mike on the last version, I tried to do this without building a whole, separate validation class. I couldn't get message to work on the 'presence' validation, so I did a separate validation function for it. I could have combined all of these into one large validation function, but I decided it was more interesting to make a number of simple validation functions instead.
|
Filled out the tests for the model and controllers. Still trying to get used to using the generator. |
| @errors = nil | ||
|
|
||
| @url = Url.new(target_link: @target) | ||
| if [email protected] |
There was a problem hiding this comment.
I prefer the happy path as the positive part of the if and the error path under else.
* if/else handling of error * Use of .blank? * Correct start of string anchor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two steps into this challenge, one commit per release.
Please review @chivygab @jaybobo @mikegee