Check-in generated code #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paholg
force-pushed
the
check-in-generated
branch
5 times, most recently
from
c1d68a1 to
4efedf2
Compare
We've had many problems with paths on various Windows setups with including generated files. Instead, we check it in, with a CI job to ensure it hasn't changed. We still generate the tests, as it's a lot of lines, and our users don't need to run that part.
paholg
force-pushed
the
check-in-generated
branch
from
4efedf2 to
8685dbb
Compare
|
Closes #217 |
paholg
added a commit
that referenced
this pull request
Feb 18, 2025
We've had many problems with paths on various Windows setups with including generated files. Instead, we check it in, with a CI job to ensure it hasn't changed. We still generate the tests, as it's a lot of lines, and our users don't need to run that part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had many problems with paths on various Windows setups with
including generated files. Instead, we check it in, with a CI job to
ensure it hasn't changed.
We still generate the tests, as it's a lot of lines, and our users don't
need to run that part.