Updated unit tests

pagopa · Feb 3, 2025 · f44db31 · f44db31
1 parent b05610e
commit f44db31
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 15 deletions.
diff --git a/...pagopa/selfcare/party/registry_proxy/connector/rest/decoder/RestTemplateErrorHandler.java b/...pagopa/selfcare/party/registry_proxy/connector/rest/decoder/RestTemplateErrorHandler.java
@@ -3,13 +3,11 @@
 import it.pagopa.selfcare.party.registry_proxy.connector.exception.InternalException;
 import it.pagopa.selfcare.party.registry_proxy.connector.exception.InvalidRequestException;
 import it.pagopa.selfcare.party.registry_proxy.connector.exception.ResourceNotFoundException;
+import java.io.IOException;
 import org.springframework.context.annotation.Configuration;
+import org.springframework.http.HttpStatus;
 import org.springframework.http.client.ClientHttpResponse;
 import org.springframework.web.client.ResponseErrorHandler;
-import org.springframework.http.HttpStatus;
-import org.springframework.http.HttpStatusCode;
-
-import java.io.IOException;
 
 @Configuration
 public class RestTemplateErrorHandler implements ResponseErrorHandler {
@@ -25,12 +23,9 @@ public void handleError(ClientHttpResponse response) throws IOException {
             throw new InternalException("Unknown error: " + response.getStatusText());
         }
         switch (status) {
-            case BAD_REQUEST:
-                throw new InvalidRequestException(response.getStatusText());
-            case NOT_FOUND:
-                throw new ResourceNotFoundException(response.getStatusText());
-            default:
-                throw new InternalException(response.getStatusText());
+            case BAD_REQUEST -> throw new InvalidRequestException(response.getStatusText());
+            case NOT_FOUND -> throw new ResourceNotFoundException(response.getStatusText());
+            default -> throw new InternalException(response.getStatusText());
         }
     }
 }
diff --git a/...pa/selfcare/party/registry_proxy/connector/rest/decoder/RestTemplateErrorHandlerTest.java b/...pa/selfcare/party/registry_proxy/connector/rest/decoder/RestTemplateErrorHandlerTest.java
@@ -1,21 +1,21 @@
 package it.pagopa.selfcare.party.registry_proxy.connector.rest.decoder;
 
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.when;
+
 import it.pagopa.selfcare.party.registry_proxy.connector.exception.InternalException;
 import it.pagopa.selfcare.party.registry_proxy.connector.exception.InvalidRequestException;
 import it.pagopa.selfcare.party.registry_proxy.connector.exception.ResourceNotFoundException;
+import java.io.IOException;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
 import org.springframework.http.HttpStatus;
+import org.springframework.http.HttpStatusCode;
 import org.springframework.http.client.ClientHttpResponse;
 
-import java.io.IOException;
-
-import static org.junit.jupiter.api.Assertions.*;
-import static org.mockito.Mockito.when;
-
 class RestTemplateErrorHandlerTest {
     @Mock
     private ClientHttpResponse response;
@@ -28,6 +28,12 @@ void setUp() {
         MockitoAnnotations.openMocks(this);
     }
 
+    @Test
+    void handleError_shouldThrowInternalException_whenStatusNull() throws IOException {
+        when(response.getStatusCode()).thenReturn(HttpStatusCode.valueOf(999));
+        assertThrows(InternalException.class, () -> errorHandler.handleError(response));
+    }
+
     @Test
     void hasError_shouldReturnTrue_whenResponseIsError() throws IOException {
         when(response.getStatusCode()).thenReturn(HttpStatus.BAD_REQUEST);