Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-6304] feat: added checks on product phases and roles #504

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

gaetano-miglionico
Copy link
Contributor

List of Changes

  • Added a check that verifies if a user with a certain role can be assigned to a specific product directly from the dashboard by checking the phasesAdditionAllowed field in products.json
  • Added a check that verifies if the specified productRoles are valid for the given role and institution based on the data in products.json
  • Added the two additional checks to the dashboard APIs createInstitutionProductUser and addUserProductRole

Motivation and Context

The two additional checks provide further protection against improper use of the APIs

How Has This Been Tested?

  • Local tests
  • Unit tests

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gaetano-miglionico gaetano-miglionico marked this pull request as ready for review February 5, 2025 15:13
@gaetano-miglionico gaetano-miglionico requested a review from a team as a code owner February 5, 2025 15:13
@gaetano-miglionico gaetano-miglionico merged commit 5f13e6f into main Feb 6, 2025
9 checks passed
@gaetano-miglionico gaetano-miglionico deleted the feature/SELC-6304 branch February 6, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants