Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5224] feat: add product pagoPa condition in createDelegation #462

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

List of Changes

  • add product pagoPa condition in createDelegation
  • add unit tests

Motivation and Context

This change was required to move product pagoPa logic from BE to BFF.
With this modification createDelegation API on ms-core is semplied and reusable.

How Has This Been Tested?

It was tested locally by running both ms-core and bff-dashboard locally and calling createDelegation API. on bff-dashboard.
It was tested with both product prod-pagopa and prod-io.

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giulia-tremolada giulia-tremolada marked this pull request as ready for review July 4, 2024 07:35
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner July 4, 2024 07:35
Copy link

sonarqubecloud bot commented Jul 4, 2024

@giulia-tremolada giulia-tremolada merged commit b6fa11e into main Jul 4, 2024
9 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-5224 branch July 4, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants