Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-5037] fix: substitute lang in BOUrl #454

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[SELC-5037] fix: substitute lang in BOUrl #454

merged 3 commits into from
Jun 12, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented Jun 12, 2024 •
edited
Loading

List of Changes

  • set lang when lang parameter is already contained in BOUrl
  • align unit tests
  • align openapi

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giulia-tremolada giulia-tremolada marked this pull request as ready for review June 12, 2024 10:30
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner June 12, 2024 10:30
@giulia-tremolada giulia-tremolada marked this pull request as draft June 12, 2024 10:31
@giulia-tremolada giulia-tremolada changed the title [SELC-5037] fix: substitute lang in BOUrl and remove lang in billingToken API [SELC-5037] fix: substitute lang in BOUrl Jun 12, 2024
@giulia-tremolada giulia-tremolada marked this pull request as ready for review June 12, 2024 10:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@giulia-tremolada giulia-tremolada merged commit 37a413e into main Jun 12, 2024
17 of 18 checks passed
@giulia-tremolada giulia-tremolada deleted the bugfix/SELC-5037 branch June 12, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuraf manuraf manuraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giulia-tremolada @manuraf