Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-5037] feat: add param lang and concat language param in BO Url #453

Merged
merged 5 commits into from
Jun 10, 2024
Merged

[SELC-5037] feat: add param lang and concat language param in BO Url #453

merged 5 commits into from
Jun 10, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented Jun 7, 2024 •
edited
Loading

List of Changes

  • add optional lang param in API /v2/products/{productId}/back-office
  • add optional lang param in API exchange/fatturazione
  • concat lang in both API response URL
  • align unit tests
  • upgrade sdk common version
  • change partyRole return type to String
  • align open api

Motivation and Context

How Has This Been Tested?

It was tested by running ms dashboard locally and calling the API

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giulia-tremolada giulia-tremolada marked this pull request as ready for review June 10, 2024 07:43
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner June 10, 2024 07:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@giulia-tremolada giulia-tremolada merged commit b413a7d into main Jun 10, 2024
9 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-5037 branch June 10, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuraf manuraf manuraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giulia-tremolada @manuraf