Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-4813] refactor: remove UserGroupController and related methods #430

Merged
merged 3 commits into from
May 9, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

List of Changes

  • remove UserGroupController
  • remove UserGroupService
  • replace UserGroupService with UserGroupV2Service
  • remove related unit tests
  • align open api

Motivation and Context

UserGroupController and related methods were no longer used.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giulia-tremolada giulia-tremolada marked this pull request as ready for review May 8, 2024 14:48
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner May 8, 2024 14:48
@giulia-tremolada giulia-tremolada changed the title [SELC-4813] feat: remove UserGroupController and related methods [SELC-4813] refactor: remove UserGroupController and related methods May 9, 2024
# Conflicts:
#	app/src/main/resources/swagger/api-docs.json
#	web/src/main/java/it/pagopa/selfcare/dashboard/web/security/ExchangeTokenService.java
#	web/src/main/java/it/pagopa/selfcare/dashboard/web/security/ExchangeTokenServiceV2.java
#	web/src/test/java/it/pagopa/selfcare/dashboard/web/security/ExchangeTokenServiceTest.java
#	web/src/test/java/it/pagopa/selfcare/dashboard/web/security/ExchangeTokenServiceV2Test.java
Copy link

sonarqubecloud bot commented May 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@manuraf manuraf merged commit 669f1e0 into main May 9, 2024
5 of 6 checks passed
@manuraf manuraf deleted the feature/SELC-4813 branch May 9, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants