Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-4660] feat: getDelegations with search and pagination filters #421

Merged
merged 12 commits into from
May 6, 2024
Merged

[SELC-4660] feat: getDelegations with search and pagination filters #421

merged 12 commits into from
May 6, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented Apr 19, 2024 •
edited
Loading

List of Changes

  • add search, taxCode, mode, order, page and size as optional parameters in API getDelegationUsingTo
  • remove OnboardingController and related methods because they were no loger used
  • align dashboard and core open-api
  • align and add unit tests

Motivation and Context

How Has This Been Tested?

It was tested by running dashboard locally and calling both getDelegationUsingTo and getDelegationUsingFrom APIs.

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giulia-tremolada giulia-tremolada changed the title [SELC-4660] feat: getDelegations with search filter and paginated [SELC-4660] feat: getDelegations with search and pagination filters Apr 22, 2024
@giulia-tremolada giulia-tremolada marked this pull request as ready for review April 22, 2024 09:12
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner April 22, 2024 09:12
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@giulia-tremolada giulia-tremolada merged commit f3c8a79 into main May 6, 2024
6 of 7 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-4660 branch May 6, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuraf manuraf manuraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giulia-tremolada @manuraf