Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-3964] - Mapped fields of institution from token's Institution data #312

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

empassaro
Copy link
Contributor

List of Changes

Obtained InstitutionUpdate object from Token entity, and used some of its data to map the institution to return

Motivation and Context

The api that allows you to show a pending onboarding data, used to get the institution data from the Institution collection. Instead now some of the institution data is obtained from the Token collection.

How Has This Been Tested?

Local env

@empassaro empassaro requested a review from a team as a code owner January 11, 2024 16:43
andrea-putzu
andrea-putzu previously approved these changes Jan 11, 2024
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

@gianmarcoplutino gianmarcoplutino self-requested a review January 12, 2024 09:53
@empassaro empassaro merged commit 6317639 into release-dev Jan 12, 2024
3 checks passed
flaminiaScarciofolo added a commit that referenced this pull request Jan 12, 2024
* [SELC-3407] Feat: API for token/exchange/fatturazione (#292)

* added first implementation of exchange/fatturazione

* remove duplication and fix tests

* [SELC-3464] Removed null and empty objects from REST response in exchange/fatturazione and {productId}/back-office (#296)

* [SELC-3485] Set resource request and limits - DEV (#300)

* Added tag external-v2 for automatic generation of open-api (#303)

Co-authored-by: [email protected] <Aiap1955?^@#>

* Change path for backoffice pagopa client (#304)

Co-authored-by: [email protected] <Aiap1955?^@#>

* Update github action with new tool to check breaking changes (#306)

Co-authored-by: [email protected] <Aiap1955?^@#>

* [SELC-3607] Increase replicas - DEV (#310)

* [SELC-3964] - Mapped fields of institution from token's Institution data (#312)

* feature: mapped some fields of institution data from InstitutionUpdate object persisted in token.

* fix: sonar issue.

---------

Co-authored-by: Manuel Rafeli <[email protected]>
Co-authored-by: Andrea Grillo <[email protected]>
Co-authored-by: pierpaolodidato89 <[email protected]>
Co-authored-by: [email protected] <Aiap1955?^@#>
Co-authored-by: empassaro <[email protected]>
Co-authored-by: andrea-putzu <[email protected]>
@empassaro empassaro deleted the feature/SELC-3964 branch January 12, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants