fix(PN-13485 ) Fix a11y for filter of notification and delegation #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leleOFA
requested review from
ZorbaDimatteo,
AndreaCimini90 and
a team
as code owners
SarahDonvito
changed the title
leleOFA
changed the title
AndreaCimini90
requested changes
Feb 25, 2025
...ages/pn-personafisica-webapp/src/components/Notifications/FilterNotificationsFormActions.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personafisica-webapp/src/components/Notifications/DesktopNotifications.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personafisica-webapp/src/components/Notifications/DesktopNotifications.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personafisica-webapp/src/components/Notifications/FilterNotifications.tsx
Outdated
Show resolved
Hide resolved
| @@ -2,7 +2,7 @@ import { FormikErrors, FormikTouched, FormikValues } from 'formik'; | |||
| import { ChangeEvent, Fragment } from 'react'; | |||
There was a problem hiding this comment.
restore the old version but keep the helperText for the date component
packages/pn-personagiuridica-webapp/src/components/Deleghe/DelegationsOfTheCompany.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/components/Deleghe/DelegationsOfTheCompany.tsx
Outdated
Show resolved
Hide resolved
...ages/pn-personagiuridica-webapp/src/components/Notifications/FilterNotificationsFormBody.tsx
Show resolved
Hide resolved
AndreaCimini90
requested changes
Feb 26, 2025
packages/pn-personagiuridica-webapp/src/components/Deleghe/DelegationsOfTheCompany.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personafisica-webapp/src/components/Notifications/FilterNotifications.tsx
Outdated
Show resolved
Hide resolved
...ages/pn-personafisica-webapp/src/components/Notifications/FilterNotificationsFormActions.tsx
Outdated
Show resolved
Hide resolved
ZorbaDimatteo
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
fix a11y for pf on filter notification and pg for filter of delegation
List of changes proposed in this pull request
How to test
1-insert wrong date and shown/hear message