Feature/pn-10866 - Add layer for statistics data transformation (PA) #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add types for echarts library chore: some minor changes to PnEcharts component
feat: add ability to override default theme to PnEcharts component feat: add FiledNotificationsStatistics component to test PnEcharts component
- add abstract StatisticsData class and its concrete implementations to generate parsed data for each type - add StatisticsDataFactory responsible to create objects of type StatisticsData - add StatisticsDataFactoryManager responsible to create and manage a single StatisticsDataFactory instance - change statistics.mock.ts to handle DTO changes - change Statistics.api.ts to pass the response object to the factory instance and get parsed data ready to be used by every statistics component
…sData subtypes chore: move StatisticsParsedData and StatisticsDataTypes definitions into models/Statistics.ts feat: add StatisticsParsedResponse type and save proper statistics data into redux store fix: filter for digital delivery mode inside any digital-related StatisticsData subclass while parsing
ghost
requested review from
ZorbaDimatteo,
AndreaCimini90 and
a team
as code owners
ghost
changed the title
ZorbaDimatteo
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the utility/StatisticsData module inside the pa-webapp to achieve the goal of performing data transformation from the dto received from the be to a collection of data structures which are ready to be used by the components which form the sender dashboard.
List of changes proposed in this pull request
How to test
Go to Statistics page and verify the statistics slice of the redux store got updated with proper data
Be sure to set the IS_STATISTICS_ENABLED environment variable to true in conf/config.json