Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download notification documents bff api - pn-10889 #1199

Merged
merged 7 commits into from
May 13, 2024
Merged

Download notification documents bff api - pn-10889 #1199

merged 7 commits into from
May 13, 2024

Conversation

AndreaCimini90
Copy link
Contributor

Short description

Migrated the delivery and delivery push api to the bff ones for the download of the notification documents

List of changes proposed in this pull request (PA/PF/PG)

  • Auto generated client
  • Removed methods from api layer (Notifications.api.ts)
  • Updated redux layer using the auto generated api client
  • Updated the NotificationDetail page and components
  • Removed the management of the downloads through redux state
  • Updated tests

How to test (PA/PF/PG)

  • Login and go to the notification detail -> try to download the documents in "Documenti allegati", "AVVISO DI AVVENUTA RICEZIONE" and in the timeline
  • Do the first check for multi recipient notifications
  • Do the first check for a notification oldest than 120 days and check that the retryAfter alert is shown
  • Do the first check with a delegated user

@AndreaCimini90 AndreaCimini90 requested review from ZorbaDimatteo and a team as code owners May 7, 2024 09:46
@AndreaCimini90 AndreaCimini90 changed the base branch from develop to feat/pn-4727 May 7, 2024 09:46
@AndreaCimini90 AndreaCimini90 merged commit 0586a3b into feat/pn-4727 May 13, 2024
13 checks passed
@AndreaCimini90 AndreaCimini90 deleted the feat/pn-10889 branch May 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZorbaDimatteo ZorbaDimatteo ZorbaDimatteo approved these changes

Assignees

@ZorbaDimatteo ZorbaDimatteo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreaCimini90 @ZorbaDimatteo