feat(pn-10953): Mandate api migration (#1209)

pagopa · May 20, 2024 · c85c72f · c85c72f
1 parent aa6fda2
commit c85c72f
Show file tree

Hide file tree

Showing 97 changed files with 5,586 additions and 1,615 deletions.
diff --git a/packages/pn-commons/src/utility/redux.utility.ts b/packages/pn-commons/src/utility/redux.utility.ts
@@ -53,15 +53,15 @@ export function parseError(e: any) {
  * D'altro canto, la funzione che si passa verso performThunkAction può avere parametri, e può realizzare azione più complesse
  * che chiamare un'API senza parametri, o con i parametri che vengono passati. Un esempio
 
-  export const acceptDelegation = createAsyncThunk<
+  export const acceptMandate = createAsyncThunk<
     AcceptDelegationResponse,
     { id: string; code: string }
-  >('acceptDelegation', 
+  >('acceptMandate', 
     performThunkAction(async ({id, code}: { id: string; code: string }) => {
       const data = {
         verificationCode: code,
       };
-      return await DelegationsApi.acceptDelegation(id, data);
+      return await DelegationsApi.acceptMandate(id, data);
     })
   );
 

diff --git a/packages/pn-personafisica-webapp/openapitools.json b/packages/pn-personafisica-webapp/openapitools.json
@@ -58,6 +58,17 @@
           "modelPackage": "models",
           "cleanupOutput": true
         }
+      },
+      "bff-mandate": {
+        "generatorName": "typescript-axios",
+        "inputSpec": "https://raw.githubusercontent.com/pagopa/pn-bff/develop/docs/openapi/api-external-pn-bff-recipient-mandate.yaml",
+        "output": "./src/generated-client/mandate",
+        "additionalProperties": {
+          "supportsES6": true,
+          "apiPackage": "apis",
+          "modelPackage": "models",
+          "cleanupOutput": true
+        }
       }
     }
   }

diff --git a/packages/pn-personafisica-webapp/src/App.tsx b/packages/pn-personafisica-webapp/src/App.tsx
@@ -34,7 +34,6 @@ import Router from './navigation/routes';
 import * as routes from './navigation/routes.const';
 import { getCurrentAppStatus } from './redux/appStatus/actions';
 import { logout } from './redux/auth/actions';
-import { Delegation } from './redux/delegation/types';
 import { useAppDispatch, useAppSelector } from './redux/hooks';
 import { getDomicileInfo, getSidemenuInformation } from './redux/sidemenu/actions';
 import { RootState } from './redux/store';
@@ -149,7 +148,7 @@ const App = () => {
         label: t('title', { ns: 'notifiche' }),
         route: routes.NOTIFICHE,
       };
-      const mappedDelegators = delegators.map((delegator: Delegation) => ({
+      const mappedDelegators = delegators.map((delegator) => ({
         label:
           'delegator' in delegator && delegator.delegator
             ? `${delegator.delegator.displayName}`

diff --git a/packages/pn-personafisica-webapp/src/__mocks__/CreateDelegation.mock.ts b/packages/pn-personafisica-webapp/src/__mocks__/CreateDelegation.mock.ts
@@ -1,6 +1,6 @@
 import { RecipientType } from '@pagopa-pn/pn-commons';
 
-import { CreateDelegationResponse, NewDelegationFormProps } from '../redux/delegation/types';
+import { NewDelegationFormProps } from '../redux/delegation/types';
 
 export const createDelegationPayload: NewDelegationFormProps = {
   selectPersonaFisicaOrPersonaGiuridica: RecipientType.PF,
@@ -20,24 +20,6 @@ export const createDelegationSelectedPayload: NewDelegationFormProps = {
   enti: [{ name: 'test', id: 'test' }],
 };
 
-export const createDelegationResponse: CreateDelegationResponse = {
-  datefrom: '2022-01-01',
-  dateto: '2022-01-02',
-  delegate: {
-    firstName: 'nome',
-    lastName: 'cognome',
-    displayName: 'nome cognome',
-    fiscalCode: 'fiscalCode',
-    companyName: 'companyName',
-    person: true,
-  },
-  delegator: null,
-  mandateId: '1',
-  status: 'pending',
-  verificationCode: '00000',
-  visibilityIds: [],
-};
-
 export const createDelegationGenericErrorResponse = {
   status: 401,
 };

diff --git a/packages/pn-personafisica-webapp/src/__mocks__/Delegations.mock.ts b/packages/pn-personafisica-webapp/src/__mocks__/Delegations.mock.ts
@@ -1,6 +1,6 @@
-import { CreateDelegationProps, Delegate, Delegator } from '../redux/delegation/types';
+import { Delegate, Delegator, NewMandateRequest } from '../redux/delegation/types';
 
-export const mockCreateDelegation: CreateDelegationProps = {
+export const mockCreateDelegation: NewMandateRequest = {
   delegate: {
     firstName: 'Davide',
     lastName: 'Legato',
@@ -19,7 +19,7 @@ export const mockCreateDelegation: CreateDelegationProps = {
   dateto: '2022-04-16',
 };
 
-export const arrayOfDelegates: Array<Delegate> = [
+export const mandatesByDelegator: Array<Delegate> = [
   {
     mandateId: '1',
     delegate: {
@@ -64,7 +64,7 @@ export const arrayOfDelegates: Array<Delegate> = [
   },
 ];
 
-export const arrayOfDelegators: Array<Delegator> = [
+export const mandatesByDelegate: Array<Delegator> = [
   {
     mandateId: '3',
     delegator: {

diff --git a/packages/pn-personafisica-webapp/src/__test__/App.test.tsx b/packages/pn-personafisica-webapp/src/__test__/App.test.tsx
@@ -10,9 +10,8 @@ import { currentStatusDTO } from '../__mocks__/AppStatus.mock';
 import { userResponse } from '../__mocks__/Auth.mock';
 import { tosPrivacyConsentMock } from '../__mocks__/Consents.mock';
 import { digitalAddresses } from '../__mocks__/Contacts.mock';
-import { arrayOfDelegators } from '../__mocks__/Delegations.mock';
+import { mandatesByDelegate } from '../__mocks__/Delegations.mock';
 import { apiClient } from '../api/apiClients';
-import { DELEGATIONS_BY_DELEGATE } from '../api/delegations/delegations.routes';
 import {
   RenderResult,
   act,
@@ -109,7 +108,7 @@ describe('App', async () => {
     mock.onGet('/bff/v1/tos-privacy').reply(200, tosPrivacyConsentMock(true, true));
     mock.onGet('downtime/v1/status').reply(200, currentStatusDTO);
     mock.onGet('/bff/v1/addresses').reply(200, digitalAddresses);
-    mock.onGet(DELEGATIONS_BY_DELEGATE()).reply(200, arrayOfDelegators);
+    mock.onGet('/bff/v1/mandate/delegate').reply(200, mandatesByDelegate);
     await act(async () => {
       result = render(<Component />, { preloadedState: reduxInitialState });
     });
@@ -127,7 +126,7 @@ describe('App', async () => {
     mock.onGet('/bff/v1/tos-privacy').reply(200, tosPrivacyConsentMock(true, true));
     mock.onGet('downtime/v1/status').reply(200, currentStatusDTO);
     mock.onGet('/bff/v1/addresses').reply(200, digitalAddresses);
-    mock.onGet(DELEGATIONS_BY_DELEGATE()).reply(200, arrayOfDelegators);
+    mock.onGet('/bff/v1/mandate/delegate').reply(200, mandatesByDelegate);
     await act(async () => {
       result = render(<Component />, { preloadedState: reduxInitialState });
     });
@@ -161,7 +160,7 @@ describe('App', async () => {
     mock.onGet('/bff/v1/tos-privacy').reply(500);
     mock.onGet('downtime/v1/status').reply(200, currentStatusDTO);
     mock.onGet('/bff/v1/addresses').reply(200, digitalAddresses);
-    mock.onGet(DELEGATIONS_BY_DELEGATE()).reply(200, arrayOfDelegators);
+    mock.onGet('/bff/v1/mandate/delegate').reply(200, mandatesByDelegate);
     await act(async () => {
       result = render(<Component />, { preloadedState: reduxInitialState });
     });
@@ -175,7 +174,7 @@ describe('App', async () => {
     mock.onGet('/bff/v1/tos-privacy').reply(200, tosPrivacyConsentMock(false, false));
     mock.onGet('downtime/v1/status').reply(200, currentStatusDTO);
     mock.onGet('/bff/v1/addresses').reply(200, digitalAddresses);
-    mock.onGet(DELEGATIONS_BY_DELEGATE()).reply(200, arrayOfDelegators);
+    mock.onGet('/bff/v1/mandate/delegate').reply(200, mandatesByDelegate);
     await act(async () => {
       result = render(<Component />, { preloadedState: reduxInitialState });
     });
@@ -191,7 +190,7 @@ describe('App', async () => {
     mock.onGet('/bff/v1/tos-privacy').reply(200, tosPrivacyConsentMock(false, false));
     mock.onGet('downtime/v1/status').reply(200, currentStatusDTO);
     mock.onGet('/bff/v1/addresses').reply(200, digitalAddresses);
-    mock.onGet(DELEGATIONS_BY_DELEGATE()).reply(200, arrayOfDelegators);
+    mock.onGet('/bff/v1/mandate/delegate').reply(200, mandatesByDelegate);
     await act(async () => {
       render(<Component />, { preloadedState: reduxInitialState });
     });
@@ -208,7 +207,7 @@ describe('App', async () => {
     mock.onGet('/bff/v1/tos-privacy').reply(200, tosPrivacyConsentMock(true, true));
     mock.onGet('downtime/v1/status').reply(200, currentStatusDTO);
     mock.onGet('/bff/v1/addresses').reply(200, digitalAddresses);
-    mock.onGet(DELEGATIONS_BY_DELEGATE()).reply(200, arrayOfDelegators);
+    mock.onGet('/bff/v1/mandate/delegate').reply(200, mandatesByDelegate);
     await act(async () => {
       result = render(<Component />, { preloadedState: reduxInitialState });
     });
@@ -223,7 +222,7 @@ describe('App', async () => {
     mock.onGet('/bff/v1/tos-privacy').reply(200, tosPrivacyConsentMock(true, true));
     mock.onGet('downtime/v1/status').reply(200, currentStatusDTO);
     mock.onGet('/bff/v1/addresses').reply(200, digitalAddresses);
-    mock.onGet(DELEGATIONS_BY_DELEGATE()).reply(200, []);
+    mock.onGet('/bff/v1/mandate/delegate').reply(200, []);
     await act(async () => {
       result = render(<Component />, { preloadedState: reduxInitialState });
     });

diff --git a/packages/pn-personafisica-webapp/src/api/delegations/Delegations.api.ts b/packages/pn-personafisica-webapp/src/api/delegations/Delegations.api.ts