fix: delete comment

pagopa · Feb 6, 2025 · 753d82e · 753d82e
1 parent 48285c0
commit 753d82e
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 109 deletions.
diff --git a/packages/pn-commons/src/components/CustomTooltip.tsx b/packages/pn-commons/src/components/CustomTooltip.tsx
@@ -17,7 +17,6 @@ const CustomTooltip: React.FC<Props> = ({
   onOpen,
   tooltipProps,
 }) => {
-  // tooltip state
   const [open, setOpen] = useState(false);
   const handleTooltipClose = () => {
     if (openOnClick) {
@@ -30,16 +29,14 @@ const CustomTooltip: React.FC<Props> = ({
       setOpen(!open);
     }
   };
-  const tooltipId = `tooltip-${Math.random().toString(36).substr(2, 9)}`; // Genera un ID unico per ogni tooltip
+  const tooltipId = `tooltip-${Math.random().toString(36).substr(2, 9)}`;
 
-  // Funzione per gestire il focus su tastiera
   const handleFocus = () => {
-    handleTooltipOpen(); // Apre il tooltip quando l'elemento riceve il focus
+    handleTooltipOpen();
   };
 
-  // Funzione per gestire il mouseover
   const handleMouseOver = () => {
-    handleTooltipOpen(); // Apre il tooltip quando il mouse passa sopra l'elemento
+    handleTooltipOpen();
   };
 
   return (
@@ -52,20 +49,20 @@ const CustomTooltip: React.FC<Props> = ({
       disableHoverListener={openOnClick}
       enterTouchDelay={0}
       onOpen={onOpen}
-      aria-live="polite" // Tooltip letto dal lettore di schermo quando visibile
-      aria-describedby={open ? tooltipId : undefined} // Associa il tooltip se visibile
+      aria-live="polite"
+      aria-describedby={open ? tooltipId : undefined}
       {...tooltipProps}
     >
       {openOnClick
         ? cloneElement(children, {
-            onClick: () => handleTooltipOpen(), // Apre il tooltip su click
-            'aria-describedby': tooltipId, // Associa il tooltip all'elemento
+            onClick: () => handleTooltipOpen(),
+            'aria-describedby': tooltipId,
           })
         : cloneElement(children, {
-            onFocus: handleFocus, // Apre il tooltip su focus
-            onMouseOver: handleMouseOver, // Apre il tooltip su mouseover
+            onFocus: handleFocus,
+            onMouseOver: handleMouseOver,
             'aria-describedby': tooltipId,
-            tabIndex: 0, // Associa il tooltip all'elemento
+            tabIndex: 0,
           })}
     </Tooltip>
   );

diff --git a/packages/pn-commons/src/components/Data/PnTable/PnTableBodyCell.tsx b/packages/pn-commons/src/components/Data/PnTable/PnTableBodyCell.tsx
@@ -1,39 +1,20 @@
 import { Box, SxProps, TableCell } from '@mui/material';
-/* import { ButtonNaked } from '@pagopa/mui-italia';
-
-import { buttonNakedInheritStyle } from '../../../utility'; */
 
 export type PnTableBodyCellProps = {
   testId?: string;
   cellProps?: SxProps;
-  // onClick?: () => void;
   children: React.ReactNode;
 };
 
-const PnTableBodyCell: React.FC<PnTableBodyCellProps> = ({
-  testId,
-  cellProps,
-  children,
-  // onClick,
-}) => (
+const PnTableBodyCell: React.FC<PnTableBodyCellProps> = ({ testId, cellProps, children }) => (
   <TableCell
     scope="col"
     data-testid={testId}
     sx={{
       ...cellProps!,
       borderBottom: 'none',
     }}
-    // onClick={onClick}
   >
-    {/*   {onClick && (
-      <>
-        {/* Even there is a onClick function on the TableCell, leave ButtonNaked below as is.
-            This makes spacebar key with accessibility to trigger the onClick function.
-            The ButtonNaked "inherits" the onClick action from the outer TableCell, so that is not necessary to replicate it. }
-        <ButtonNaked sx={buttonNakedInheritStyle}>{children}</ButtonNaked>
-      </>
-    )} */}
-    {/* !onClick && <Box>{children}</Box> */}
     <Box>{children}</Box>
   </TableCell>
 );

diff --git a/packages/pn-commons/src/components/Data/PnTable/__test__/PnTableBodyCell.test.tsx b/packages/pn-commons/src/components/Data/PnTable/__test__/PnTableBodyCell.test.tsx
@@ -4,8 +4,6 @@ import PnTableBodyCell from '../PnTableBodyCell';
 describe('PnTableBodyCell', () => {
   disableConsoleLogging('error');
 
-  // const mockFn = vi.fn();
-
   it('render component', () => {
     const { container, queryByTestId } = render(
       <PnTableBodyCell>mocke-cell-content</PnTableBodyCell>
@@ -14,18 +12,4 @@ describe('PnTableBodyCell', () => {
     const buttons = queryByTestId('cell.button');
     expect(buttons).not.toBeInTheDocument();
   });
-
-  /*  it('click cell event', () => {
-    const { getByTestId } = render(
-      <PnTableBodyCell
-        testId="cell"
-        // onClick={() => mockFn()}
-      >
-        mocke-cell-content
-      </PnTableBodyCell>
-    );
-    const cell = getByTestId('cell');
-    fireEvent.click(cell);
-    expect(mockFn).toBeCalledTimes(1);
-  }); */
 });
diff --git a/packages/pn-commons/src/components/Data/SmartTable/__test__/SmartData.test.tsx b/packages/pn-commons/src/components/Data/SmartTable/__test__/SmartData.test.tsx
@@ -150,12 +150,6 @@ describe('SmartData', () => {
     const sortToggle = within(table).getByTestId(`headerCellDesktop.sort.${sortableColumn!.id}`);
     fireEvent.click(sortToggle);
     expect(handleSort).toHaveBeenCalledTimes(1);
-    /* const clickableColumnIdx = smartCfg.findIndex((cfg) => cfg.tableConfiguration.onClick);
-    const rows = within(table).getAllByTestId('bodyRowDesktop');
-    // we can take the row we want
-    const cells = within(rows[0]).getAllByTestId('rowCellDesktop');
-    fireEvent.click(cells[clickableColumnIdx]);
-    expect(handleColumnClick).toHaveBeenCalledTimes(1); */
   });
 
   it('no sort available (desktop version)', () => {

diff --git a/packages/pn-commons/src/components/Data/__test__/PnTable.test.tsx b/packages/pn-commons/src/components/Data/__test__/PnTable.test.tsx
@@ -102,29 +102,6 @@ describe('PnTable Component', () => {
     });
   });
 
-  /* it('sorts a column', () => {
-    const { getByRole } = render(<RenderPnTable />);
-    const table = getByRole('table');
-    const tableHead = within(table).getByTestId('table-test.header');
-    const firstColumn = within(tableHead).getAllByTestId('table-test.header.cell')[0];
-    const sortButton = within(firstColumn).getByRole('button');
-    expect(sortButton).toBeInTheDocument();
-    fireEvent.click(sortButton);
-    expect(handleSort).toBeCalledTimes(1);
-    expect(handleSort).toBeCalledWith({ order: 'desc', orderBy: 'column-1' });
-  });
-
-  it('click on a column', () => {
-    const { getByRole } = render(<RenderPnTable />);
-    const table = getByRole('table');
-    const tableBody = within(table).getByTestId('table-test.body');
-    const firstRow = within(tableBody).getAllByTestId('table-test.body.row')[0];
-    const tableColumns = within(firstRow).getAllByTestId('table-test.body.row.cell');
-    fireEvent.click(tableColumns[2].querySelectorAll('button')[0]);
-    expect(handleColumnClick).toHaveBeenCalledTimes(1);
-    expect(handleColumnClick).toHaveBeenCalledWith(rows[0], columns[2].id);
-  }); */
-
   it('render component - multiple PnTableBody', () => {
     expect(() =>
       render(
@@ -133,12 +110,7 @@ describe('PnTable Component', () => {
             {rows.map((row, index) => (
               <PnTableBodyRow key={row.id} testId="table-test" index={index}>
                 {columns.map((column) => (
-                  <PnTableBodyCell
-                    key={column.id}
-                    //  onClick={() => column.onClick?.()}
-                  >
-                    {row[column.id]}
-                  </PnTableBodyCell>
+                  <PnTableBodyCell key={column.id}>{row[column.id]}</PnTableBodyCell>
                 ))}
               </PnTableBodyRow>
             ))}
@@ -147,12 +119,7 @@ describe('PnTable Component', () => {
             {rows.map((row, index) => (
               <PnTableBodyRow key={row.id} testId="table-test" index={index}>
                 {columns.map((column) => (
-                  <PnTableBodyCell
-                    key={column.id}
-                    // onClick={() => column.onClick?.()}
-                  >
-                    {row[column.id]}
-                  </PnTableBodyCell>
+                  <PnTableBodyCell key={column.id}>{row[column.id]}</PnTableBodyCell>
                 ))}
               </PnTableBodyRow>
             ))}

diff --git a/packages/pn-commons/src/components/Data/__test__/SmartTable.test.tsx b/packages/pn-commons/src/components/Data/__test__/SmartTable.test.tsx
@@ -115,11 +115,7 @@ const RenderSmartable: React.FC<{
             <SmartBodyCell
               key={column.id.toString()}
               columnId={column.id}
-              tableProps={
-                {
-                  // sonClick: column.tableConfiguration.onClick,
-                }
-              }
+              tableProps={{}}
               cardProps={column.cardConfiguration}
               isCardHeader={column.cardConfiguration?.isCardHeader}
             >
@@ -231,11 +227,7 @@ describe('Smart Table Component', () => {
                   <SmartBodyCell
                     key={column.id.toString()}
                     columnId={column.id}
-                    tableProps={
-                      {
-                        // onClick: column.tableConfiguration.onClick,
-                      }
-                    }
+                    tableProps={{}}
                     cardProps={column.cardConfiguration}
                     isCardHeader={column.cardConfiguration?.isCardHeader}
                   >

diff --git a/packages/pn-commons/src/components/Notifications/StatusTooltip.tsx b/packages/pn-commons/src/components/Notifications/StatusTooltip.tsx
@@ -34,7 +34,7 @@ const StatusTooltip = ({
         }}
         data-testid={`statusChip-${label}`}
         aria-label={isMobile ? `${label}: ${tooltip}` : undefined}
-        aria-describedby={`tooltip-${label}`} // Associa il chip al tooltip
+        aria-describedby={`tooltip-${label}`}
       />
     </CustomTooltip>
   );

diff --git a/packages/pn-commons/src/components/Pagination/CustomPagination.tsx b/packages/pn-commons/src/components/Pagination/CustomPagination.tsx
@@ -195,7 +195,7 @@ export default function CustomPagination({
                       : props2.type
                   }
                   {...props2}
-                  // sx={{ border: 'none' }}
+                  sx={{ border: 'none' }}
                 />
               );
             }}

diff --git a/packages/pn-pa-webapp/src/components/Notifications/DesktopNotifications.tsx b/packages/pn-pa-webapp/src/components/Notifications/DesktopNotifications.tsx
@@ -14,7 +14,6 @@ import {
   PnTableBodyRow,
   PnTableHeader,
   PnTableHeaderCell,
-  // Row,
   Sort,
 } from '@pagopa-pn/pn-commons';
 
@@ -154,7 +153,6 @@ const DesktopNotifications = ({
 
   const showFilters = notifications?.length > 0 || filtersApplied;
 
-  // Navigation handlers
   const handleRowClick = (iun: string) => {
     navigate(routes.GET_DETTAGLIO_NOTIFICA_PATH(iun));
   };
@@ -190,10 +188,8 @@ const DesktopNotifications = ({
                     {columns.map((column) => (
                       <PnTableBodyCell
                         key={column.id}
-                        // onClick={() => handleRowClick(row)}
                         cellProps={{
                           ...column.cellProps,
-                          // cursor: 'pointer',
                         }}
                       >
                         <NotificationsDataSwitch

diff --git a/packages/pn-personagiuridica-webapp/src/components/Notifications/DesktopNotifications.tsx b/packages/pn-personagiuridica-webapp/src/components/Notifications/DesktopNotifications.tsx
@@ -126,7 +126,6 @@ const DesktopNotifications = ({
 
   const showFilters = notifications?.length > 0 || filtersApplied;
 
-  // Navigation handlers
   const handleRowClick = (iun: string, mandateId?: string) => {
     if (isDelegatedPage && mandateId) {
       navigate(routes.GET_DETTAGLIO_NOTIFICA_DELEGATO_PATH(iun, mandateId));
@@ -163,10 +162,8 @@ const DesktopNotifications = ({
                 {columns.map((column) => (
                   <PnTableBodyCell
                     key={column.id}
-                    // onClick={() => handleRowClick(row)}
                     cellProps={{
                       ...column.cellProps,
-                      // cursor: 'pointer',
                     }}
                   >
                     <NotificationsDataSwitch