fix: fix for cr

pagopa · Feb 18, 2025 · 5b2fb31 · 5b2fb31
1 parent 795745d
commit 5b2fb31
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 19 deletions.
diff --git a/packages/pn-commons/src/components/NotificationDetail/NotificationPaymentRecipient.tsx b/packages/pn-commons/src/components/NotificationDetail/NotificationPaymentRecipient.tsx
@@ -123,7 +123,6 @@ const NotificationPaymentRecipient: React.FC<Props> = ({
   };
 
   useEffect(() => {
-    console.log('errorOnPayment :>> ', errorOnPayment);
     const unpaidPayments = pagoPaF24.some((f) => f.pagoPa?.status === PaymentStatus.REQUIRED);
     if (isSinglePayment && unpaidPayments) {
       setSelectedPayment(pagoPaF24[0] ?? { pagoPa: null });

diff --git a/...-commons/src/components/NotificationDetail/__test__/NotificationPaymentRecipient.test.tsx b/...-commons/src/components/NotificationDetail/__test__/NotificationPaymentRecipient.test.tsx
@@ -89,7 +89,7 @@ describe('NotificationPaymentRecipient Component', () => {
       expect(getByTestId('payment-error')).toBeInTheDocument();
     });
 
-    // Clicca sul radioButton per correggere l'errore
+    // Click on the radioButton to correct the error
     fireEvent.click(radioButton!);
 
     await waitFor(() => {

diff --git a/packages/pn-pa-webapp/public/locales/it/notifiche.json b/packages/pn-pa-webapp/public/locales/it/notifiche.json
@@ -27,8 +27,7 @@
     "paid": "Pagato",
     "f24-attached": "Modelli F24 allegati",
     "attachments": "allegati",
-    "f24-dialog-title": "Modelli F24 allegati alla notifica {{iun}}",
-    "error-payment": "Seleziona un avviso di pagamento"
+    "f24-dialog-title": "Modelli F24 allegati alla notifica {{iun}}"
   },
   "table": {
     "title": "Tabella delle notifiche",

diff --git a/packages/pn-personafisica-webapp/public/locales/de/deleghe.json b/packages/pn-personafisica-webapp/public/locales/de/deleghe.json
@@ -42,7 +42,8 @@
       "notificationsFrom": "Zustellungen von:",
       "allNotifications": "Alle Zustellungen",
       "active": "Aktivieren",
-      "pending": "Wartet auf Bestätigung"
+      "pending": "Wartet auf Bestätigung",
+      "menu-aria-label": "Aktionsmenü"
     },
     "revoke-successfully": "Vollmacht wurde widerrufen.",
     "reject-successfully": "Vollmacht wurde abgelehnt."

diff --git a/packages/pn-personafisica-webapp/public/locales/en/notifiche.json b/packages/pn-personafisica-webapp/public/locales/en/notifiche.json
@@ -61,6 +61,7 @@
     "show-less": "See fewer details",
     "cancelled-alert-text": "This notification has been canceled by the sending institution. You can ignore the content.",
     "disclaimer-link": "Discover more",
+    "menu-aria-label": "Actions menu",
     "payment": {
       "title": "Payment",
       "single-payment-subtitle": "The final amount may be different than what is indicated.",

diff --git a/packages/pn-personafisica-webapp/public/locales/fr/notifiche.json b/packages/pn-personafisica-webapp/public/locales/fr/notifiche.json
@@ -42,6 +42,7 @@
     "payment-table-aria-label": "Détail des paiements",
     "date": "Date d’envoi",
     "payment-terms": "À payer avant le",
+    "menu-aria-label": "Menu actions",
     "sender": "Expéditeur",
     "recipient": "Destinataire",
     "cancelled-iun": "Code IUN annulé",

diff --git a/packages/pn-personafisica-webapp/public/locales/it/notifiche.json b/packages/pn-personafisica-webapp/public/locales/it/notifiche.json
@@ -45,6 +45,7 @@
     "payment-table-aria-label": "Dettaglio pagamenti",
     "date": "Data di invio",
     "payment-terms": "Da pagare entro il",
+    "menu-aria-label": "Menù azioni",
     "sender": "Mittente",
     "recipient": "Destinatario",
     "cancelled-iun": "Codice IUN annullato",

diff --git a/packages/pn-personafisica-webapp/public/locales/sl/notifiche.json b/packages/pn-personafisica-webapp/public/locales/sl/notifiche.json
@@ -42,6 +42,7 @@
     "payment-table-aria-label": "Podrobnosti o plačilih",
     "date": "Datum pošiljanja",
     "payment-terms": "Plačati do",
+    "menu-aria-label": "Meni dejanj",
     "sender": "Pošiljatelj",
     "recipient": "Prejemnik",
     "cancelled-iun": "Koda IUN je preklicana",

diff --git a/packages/pn-personafisica-webapp/src/pages/Deleghe.page.tsx b/packages/pn-personafisica-webapp/src/pages/Deleghe.page.tsx
@@ -59,32 +59,29 @@ const Deleghe = () => {
       PFEventStrategyFactory.triggerEvent(PFEventsType.SEND_MANDATE_REVOKED);
       void dispatch(revokeMandate(id))
         .unwrap()
-        .then(() =>
-          PFEventStrategyFactory.triggerEvent(PFEventsType.SEND_MANDATE_GIVEN, { delegators })
-        )
-        .then(() => {
-          dispatch(
+        .then(
+          () =>
+            PFEventStrategyFactory.triggerEvent(PFEventsType.SEND_MANDATE_GIVEN, { delegators }),
+          void dispatch(
             appStateActions.addSuccess({
               title: '',
               message: t('deleghe.revoke-successfully'),
             })
-          );
-        });
+          )
+        );
     } else {
       PFEventStrategyFactory.triggerEvent(PFEventsType.SEND_MANDATE_REJECTED);
       void dispatch(rejectMandate(id))
         .unwrap()
-        .then(() =>
-          PFEventStrategyFactory.triggerEvent(PFEventsType.SEND_HAS_MANDATE, { delegates })
-        )
-        .then(() => {
-          dispatch(
+        .then(
+          () => PFEventStrategyFactory.triggerEvent(PFEventsType.SEND_HAS_MANDATE, { delegates }),
+          void dispatch(
             appStateActions.addSuccess({
               title: '',
               message: t('deleghe.reject-successfully'),
             })
-          );
-        });
+          )
+        );
     }
   };