fix: resolve CRs

pagopa · Mar 29, 2024 · 306458f · 306458f
1 parent d8018a7
commit 306458f
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 14 deletions.
diff --git a/packages/pn-commons/src/models/MixpanelEvents.ts b/packages/pn-commons/src/models/MixpanelEvents.ts
@@ -24,12 +24,6 @@ export type TrackedEvent<T extends object | undefined = undefined> = T extends u
   ? Partial<Record<EventPropertyType, BaseTrackedEvent | string | boolean>>
   : Partial<Record<EventPropertyType, (BaseTrackedEvent & T) | string | boolean>>;
 
-export type ProfileMapAttributes = {
-  profilePropertyType: Array<EventPropertyType>;
-  getAttributes: (payload?: any, meta?: any) => Record<string, string>;
-  shouldBlock?: (payload?: any, meta?: any) => boolean;
-};
-
 export type ActionMeta = {
   requestId: string;
   requestStatus: string;
@@ -119,6 +113,7 @@ export type EventCreatedDelegationType = {
   mandate_type: string;
 };
 
+// TODO: review that enum when implementing PG events
 export enum EventPaymentRecipientType {
   SEND_PAYMENT_DETAIL_REFRESH = 'SEND_PAYMENT_DETAIL_REFRESH',
   SEND_CANCELLED_NOTIFICATION_REFOUND_INFO = 'SEND_CANCELLED_NOTIFICATION_REFOUND_INFO',

diff --git a/packages/pn-commons/src/models/index.ts b/packages/pn-commons/src/models/index.ts
@@ -36,7 +36,6 @@ import {
   EventPaymentStatusType,
   EventPropertyType,
   EventsType,
-  ProfileMapAttributes,
   TrackedEvent,
 } from './MixpanelEvents';
 import {
@@ -198,7 +197,6 @@ export type {
   PartyEntityWithUrl,
   Product,
   PaymentCache,
-  ProfileMapAttributes,
   TrackedEvent,
   EventStrategy,
   EventType,

diff --git a/...-webapp/src/utility/MixpanelUtils/Strategies/__test__/SendHasMandateGivenStrategy.test.ts b/...-webapp/src/utility/MixpanelUtils/Strategies/__test__/SendHasMandateGivenStrategy.test.ts
@@ -1,7 +1,6 @@
 import { EventPropertyType } from '@pagopa-pn/pn-commons';
 
 import { arrayOfDelegators } from '../../../../__mocks__/Delegations.mock';
-import { DelegationStatus } from '../../../status.utility';
 import { SendHasMandateGivenStrategy } from '../SendHasMandateGivensStrategy';
 
 describe('Mixpanel - Has Mandate Given Strategy', () => {
@@ -11,10 +10,18 @@ describe('Mixpanel - Has Mandate Given Strategy', () => {
     const mandateGiven = strategy.performComputations({ payload: arrayOfDelegators });
     expect(mandateGiven).toEqual({
       [EventPropertyType.PROFILE]: {
-        SEND_MANDATE_GIVEN:
-          arrayOfDelegators.filter((d) => d.status === DelegationStatus.ACTIVE).length > 0
-            ? 'yes'
-            : 'no',
+        SEND_MANDATE_GIVEN: 'yes',
+      },
+    });
+  });
+
+  it('should return no if there are no active mandates', () => {
+    const strategy = new SendHasMandateGivenStrategy();
+
+    const mandateGiven = strategy.performComputations({ payload: [] });
+    expect(mandateGiven).toEqual({
+      [EventPropertyType.PROFILE]: {
+        SEND_MANDATE_GIVEN: 'no',
       },
     });
   });

diff --git a/...-webapp/src/utility/MixpanelUtils/Strategies/__test__/SendHasMandateLoginStrategy.test.ts b/...-webapp/src/utility/MixpanelUtils/Strategies/__test__/SendHasMandateLoginStrategy.test.ts
@@ -10,7 +10,18 @@ describe('Mixpanel - Has Mandate Login Strategy', () => {
     const mandateGiven = strategy.performComputations({ payload: arrayOfDelegators });
     expect(mandateGiven).toEqual({
       [EventPropertyType.PROFILE]: {
-        SEND_HAS_MANDATE: arrayOfDelegators.length > 0 ? 'yes' : 'no',
+        SEND_HAS_MANDATE: 'yes',
+      },
+    });
+  });
+
+  it('should return no if there are no active mandates', () => {
+    const strategy = new SendHasMandateLoginStrategy();
+
+    const mandateGiven = strategy.performComputations({ payload: [] });
+    expect(mandateGiven).toEqual({
+      [EventPropertyType.PROFILE]: {
+        SEND_HAS_MANDATE: 'no',
       },
     });
   });